CU-f34dk7 remove old mapN and expose new APIs #2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aballano
approved these changes
Mar 3, 2021
|
This is a hammer to perf, all the nested flatMaps create a new list even when zipping just 2. I'd specialise every implementation. |
raulraja
reviewed
Mar 3, 2021
| i.flatMap { ii -> | ||
| j.flatMap { jj -> | ||
| k.map { kk -> | ||
| map(bb, cc, dd, ee, ff, gg, hh, ii, jj, kk) |
raulraja
approved these changes
Mar 3, 2021
| mapN( | ||
| b, | ||
| c, | ||
| sequenceOf(Unit), |
There was a problem hiding this comment.
Does sequence(Unit) allocate new sequences or is it backed by a singleton value? If not we could optimize this.
There was a problem hiding this comment.
It's probably not backed by a singleton value.
@pakoito For all data types or just |
|
Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second, and last, step of the deprecation/removacl top-level
mapNfor nullable. So now we can expose top-levelmapNAPIs for Kotlin Std types that don't have acompanion objectto exposemapNupon.