Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow Fx: Clean-up new code & breaking changes since 0.12.0 #2333

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Arrow Fx: Clean-up new code & breaking changes since 0.12.0 #2333

merged 5 commits into from
Mar 23, 2021

Conversation

nomisRev
Copy link
Member

It also removes some newly added code that is not desired and got deprecated immediately.

  • ConcurrentVar#modify
  • ConcurrentVar#modify_
  • ConcurrentVar#withConcurrentVar
  • TMap<K, V>#plusAssign

Also, this PR reverts making UnsafePromise public in 0.12.0

@nomisRev nomisRev requested a review from a team March 23, 2021 10:13
@nomisRev nomisRev changed the title Arrow Fx: Clean-up new code & breaking changes since 0.12.0 #2332 Arrow Fx: Clean-up new code & breaking changes since 0.12.0 Mar 23, 2021
franciscodr
franciscodr approved these changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nomisRev!

raulraja
raulraja approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nomisRev !

danimontoya
danimontoya approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@danimontoya danimontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nomisRev 🙌

@nomisRev nomisRev merged commit 3180a98 into master Mar 23, 2021
@nomisRev nomisRev deleted the sv-clean-up-arrow-fx-api-change branch March 23, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimontoya danimontoya danimontoya approved these changes

@franciscodr franciscodr franciscodr approved these changes

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nomisRev @raulraja @franciscodr @danimontoya