Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade KotlinTest to Kotest #2405

Merged
merged 11 commits into from
May 21, 2021
Merged

Upgrade KotlinTest to Kotest #2405

merged 11 commits into from
May 21, 2021

Conversation

nomisRev
Copy link
Member

In preparation for moving test to common module for the MPP setup this PR upgrades KotlinTest to Kotest. (With the exception of the old Arrow Meta Kapt module)

This PR keeps everything as is as much as possible.
In almost all files only the following changes were applied:

  • forAll => checkAll
    • == => shouldBe as forAll expected Boolean but checkAll uses assertions
  • Gen => Arb

@nomisRev nomisRev added the MPP Tickets belonging to Arrow Multiplatform Support label May 21, 2021
@nomisRev nomisRev requested review from raulraja, aballano, rachelcarmena and a team May 21, 2021 12:18
@franciscodr
Copy link
Collaborator

Copy link
Member

@rachelcarmena rachelcarmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING @nomisRev !! Just 2 small things:

  • Move code Arrow-Core #2403 is ready to merge in case you want to check all the changes together
  • Kotest version could be updated from 4.3.1 to 4.6.0

Congrats!!! 👏 🚀

@nomisRev
Copy link
Member Author

@rachelcarmena bumped to 4.6.0.

Now some conflcits to fix 😅

Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nomisRev 🙏

@nomisRev nomisRev merged commit 1b16515 into main May 21, 2021
@nomisRev nomisRev deleted the cu-j98mr4-upgrade-to-kotest branch May 21, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPP Tickets belonging to Arrow Multiplatform Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants