Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Float & Double comparison operators #2440

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Deprecate Float & Double comparison operators #2440

merged 2 commits into from
Jul 7, 2021

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Jul 5, 2021

Due to the way that floating numbers work in Kotlin MPP, we cannot support comparison operators for them (Float, Double).

https://kotlinlang.org/docs/equality.html#floating-point-numbers-equality

@nomisRev nomisRev added the MPP Tickets belonging to Arrow Multiplatform Support label Jul 5, 2021
@nomisRev nomisRev requested a review from a team July 5, 2021 18:26
i-walker
i-walker approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@i-walker i-walker requested a review from a team July 6, 2021 12:04
raulraja
raulraja approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nomisRev !

@nomisRev nomisRev merged commit 5e0db6b into main Jul 7, 2021
@nomisRev nomisRev deleted the sv-deprecate-floating-point-comparison branch July 7, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@i-walker i-walker i-walker approved these changes

Assignees
No one assigned
Labels
MPP Tickets belonging to Arrow Multiplatform Support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @raulraja @i-walker