Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test impl atomic on JS #2455

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Fix test impl atomic on JS #2455

merged 2 commits into from
Jul 26, 2021

Conversation

nomisRev
Copy link
Member

There was a failing test on JS for values x, y, z => 1f, 1f, 0f.

It does a reference check in compareAndSet underneath, and on JS this made the test fail for x and y of the same value.

@nomisRev nomisRev requested a review from a team July 25, 2021 19:13
raulraja
raulraja approved these changes Jul 25, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @nomisRev !

@nomisRev nomisRev merged commit d0198d1 into main Jul 26, 2021
@nomisRev nomisRev deleted the sv-fix-flaky-atomic-test-js branch July 26, 2021 09:37
nomisRev added a commit that referenced this pull request Aug 2, 2021
@nomisRev
Fix test impl atomic on JS (#2455)
6c76826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-walker i-walker i-walker approved these changes

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nomisRev @raulraja @i-walker