Fix dependencies and run native tests #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
reviewed
Sep 13, 2021
nomisRev
reviewed
Sep 14, 2021
.github/workflows/pull_request.yml
Outdated
Comment on lines
175
to
178
| tvos_and_watchos: | ||
|
|
||
| tvos: |
There was a problem hiding this comment.
Why are we splitting this up? Is this taking so much longer than macos + ios ?
Adding more macos-latest jobs will really slow down the build, since there is a low limit on how much we can run in parallel.
There was a problem hiding this comment.
yes, either that or I up the wait time
There was a problem hiding this comment.
Yes, let's combine them. Feel free to also move JS job into the Linux job at the same time.
nomisRev
reviewed
Sep 14, 2021
nomisRev
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed watchosArm64 target due to #2491