Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#266: Alias constructors for applicative builders for Try, Eval, IO #278

Merged
merged 4 commits into from
Sep 15, 2017
Merged

#266: Alias constructors for applicative builders for Try, Eval, IO #278

merged 4 commits into from
Sep 15, 2017

Conversation

anstaendig
Copy link
Contributor

Issue: #266

@codecov-io
Copy link

codecov-io commented Sep 15, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@0580ec7). Click here to learn what that means.
The diff coverage is 13.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #278   +/-   ##
=========================================
  Coverage          ?   42.49%           
  Complexity        ?      318           
=========================================
  Files             ?      148           
  Lines             ?     3949           
  Branches          ?      402           
=========================================
  Hits              ?     1678           
  Misses            ?     2150           
  Partials          ?      121
Impacted Files Coverage Δ Complexity Δ
kategory-core/src/main/kotlin/kategory/data/Try.kt 27.02% <0%> (ø) 6 <0> (?)
...ategory-core/src/main/kotlin/kategory/data/Eval.kt 45.2% <15.9%> (ø) 7 <1> (?)
...ffects/src/main/kotlin/kategory/effects/data/IO.kt 44.18% <19.35%> (ø) 10 <8> (?)
...rc/main/kotlin/kategory/typeclasses/Applicative.kt 28.98% <38.46%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0580ec7...4a48f7f. Read the comment docs.

Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first PR! Can you please rename all the constructors to merge, instead of parallel, for the reasons we spoke about yesterday.

Once that's done, we're ready to merge!

@anstaendig
Copy link
Contributor Author

Sure, I just thought it was just fitting for Eval not the rest. Will do!

invoke(op3),
invoke(op4)).ev()

fun <A, B, C, D, E> merge(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding codestyle we should follow the same conventions as in https://github.com/kategory/kategory/blob/master/kategory-core/src/main/kotlin/kategory/typeclasses/Applicative.kt. Alternatively we can change the ones in Applicative to match these one. I'll leave up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see one clear way of formatting it inApplicative.kt.

@pakoito pakoito merged commit e3256e1 into arrow-kt:master Sep 15, 2017
@pakoito
Copy link
Member

pakoito commented Sep 15, 2017

Thank you @anstaendig for the PR! I hope it helped you understand Kategory and FP a bit better :D Do ping us on Slack if you want another ticket, we can ramp up the difficulty :P

@wiyarmir wiyarmir mentioned this pull request Sep 15, 2017
rachelcarmena added a commit that referenced this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants