-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NonEmptyList.fromList deprecation to suggest toOption()
instead
#2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggest `.toOption()` instead of `Option.fromNullable()`. Coming from a discussion in StackOverFlow here https://stackoverflow.com/a/73893138/9440211.
nomisRev
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for so quickly raising a PR @StylianosGakis! 🙏
And congrats on your first-contribution 🙌 👏 🥳 |
i-walker
approved these changes
Oct 3, 2022
Awesome, thanks! 🎉 |
nomisRev
added a commit
that referenced
this pull request
Oct 5, 2022
* Add Resource.allocated() to decompose Resource into it's allocate and… (#2820) * [2743] Migrate internal use of CircuitBreaker double to duration (#2748) * Fix typo (#2824) * Make the server disconnect test more general (#2822) * Update NonEmptyList.fromList deprecation to suggest `toOption()` instead (#2832) * Improve Either.getOrHandle() docs (#2833) * Improve allocated, and fix knit examples Co-authored-by: Jeff Martin <jeff@custommonkey.org> Co-authored-by: Martin Moore <martinmoorej@gmail.com> Co-authored-by: valery1707 <valery1707@gmail.com> Co-authored-by: Lukasz Kalnik <70261110+lukasz-kalnik-gcx@users.noreply.github.com> Co-authored-by: stylianosgakis <stylianos.gakis98@gmail.com>
github-merge-queue bot
referenced
this pull request
in elide-dev/elide
Jul 23, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.arrow-kt:arrow-fx-coroutines](https://togithub.com/arrow-kt/arrow) | `1.1.3` -> `1.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.arrow-kt:arrow-fx-coroutines/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.arrow-kt:arrow-fx-coroutines/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.arrow-kt:arrow-fx-coroutines/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.arrow-kt:arrow-fx-coroutines/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.arrow-kt:arrow-optics-ksp-plugin](https://togithub.com/arrow-kt/arrow) | `1.1.3` -> `1.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.arrow-kt:arrow-optics-ksp-plugin/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.arrow-kt:arrow-optics-ksp-plugin/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.arrow-kt:arrow-optics-ksp-plugin/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.arrow-kt:arrow-optics-ksp-plugin/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.arrow-kt:arrow-optics](https://togithub.com/arrow-kt/arrow) | `1.1.3` -> `1.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.arrow-kt:arrow-optics/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.arrow-kt:arrow-optics/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.arrow-kt:arrow-optics/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.arrow-kt:arrow-optics/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.arrow-kt:arrow-core](https://togithub.com/arrow-kt/arrow) | `1.1.3` -> `1.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.arrow-kt:arrow-core/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.arrow-kt:arrow-core/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.arrow-kt:arrow-core/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.arrow-kt:arrow-core/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [io.arrow-kt:arrow-stack](https://togithub.com/arrow-kt/arrow) | `1.1.3` -> `1.2.0` | [![age](https://developer.mend.io/api/mc/badges/age/maven/io.arrow-kt:arrow-stack/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/io.arrow-kt:arrow-stack/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/io.arrow-kt:arrow-stack/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/io.arrow-kt:arrow-stack/1.1.3/1.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>arrow-kt/arrow (io.arrow-kt:arrow-fx-coroutines)</summary> ### [`v1.2.0`](https://togithub.com/arrow-kt/arrow/releases/tag/1.2.0) [Compare Source](https://togithub.com/arrow-kt/arrow/compare/1.1.5...1.2.0) ##### What's Changed - Add CNAME file to Dokka output by [@​franciscodr](https://togithub.com/franciscodr) in [https://github.com/arrow-kt/arrow/pull/3029](https://togithub.com/arrow-kt/arrow/pull/3029) - Remove legacy site code by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/3030](https://togithub.com/arrow-kt/arrow/pull/3030) - Update README by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3033](https://togithub.com/arrow-kt/arrow/pull/3033) - Cancel previous PR action on new commit by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/3032](https://togithub.com/arrow-kt/arrow/pull/3032) - Remove legacy script files by [@​franciscodr](https://togithub.com/franciscodr) in [https://github.com/arrow-kt/arrow/pull/3034](https://togithub.com/arrow-kt/arrow/pull/3034) - Ensure optics type with "data" modifier is a class by [@​DeoTimeTheGithubUser](https://togithub.com/DeoTimeTheGithubUser) in [https://github.com/arrow-kt/arrow/pull/3036](https://togithub.com/arrow-kt/arrow/pull/3036) - Update all dependencies (major) by [@​renovate](https://togithub.com/renovate) in [https://github.com/arrow-kt/arrow/pull/3042](https://togithub.com/arrow-kt/arrow/pull/3042) - Remove test dependency from Arrow Fx by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/3046](https://togithub.com/arrow-kt/arrow/pull/3046) - Bump Kotlin, KSP and coroutines version by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/3047](https://togithub.com/arrow-kt/arrow/pull/3047) - fix mapIndexed when collecting multiple times by [@​hoc081098](https://togithub.com/hoc081098) in [https://github.com/arrow-kt/arrow/pull/3056](https://togithub.com/arrow-kt/arrow/pull/3056) - Update versions by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/3058](https://togithub.com/arrow-kt/arrow/pull/3058) - optics ksp plugin: fixed handling of variance ([#​3057](https://togithub.com/arrow-kt/arrow/issues/3057)) by [@​vladd-g](https://togithub.com/vladd-g) in [https://github.com/arrow-kt/arrow/pull/3060](https://togithub.com/arrow-kt/arrow/pull/3060) - Fixes recover inconsistency with raise DSL on types other than Either by [@​yoxjames](https://togithub.com/yoxjames) in [https://github.com/arrow-kt/arrow/pull/3052](https://togithub.com/arrow-kt/arrow/pull/3052) - Change NonEmptySet type parameter name from T to A by [@​franciscodr](https://togithub.com/franciscodr) in [https://github.com/arrow-kt/arrow/pull/3062](https://togithub.com/arrow-kt/arrow/pull/3062) - Add withError and (Eager)Effect.mapError by [@​kyay10](https://togithub.com/kyay10) in [https://github.com/arrow-kt/arrow/pull/3059](https://togithub.com/arrow-kt/arrow/pull/3059) - Update versions of several libraries by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3017](https://togithub.com/arrow-kt/arrow/pull/3017) - Add merge builder for raise by [@​kyay10](https://togithub.com/kyay10) in [https://github.com/arrow-kt/arrow/pull/3061](https://togithub.com/arrow-kt/arrow/pull/3061) - Update all dependencies by [@​renovate](https://togithub.com/renovate) in [https://github.com/arrow-kt/arrow/pull/3065](https://togithub.com/arrow-kt/arrow/pull/3065) - Update dependency gradle to v8.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/arrow-kt/arrow/pull/3070](https://togithub.com/arrow-kt/arrow/pull/3070) - Fix warnings of single-subclass sealed classes by [@​jooohn](https://togithub.com/jooohn) in [https://github.com/arrow-kt/arrow/pull/3067](https://togithub.com/arrow-kt/arrow/pull/3067) - KDoc for `Raise#raise`, `Raise#ensure` and `Raise#ensureNotNull` by [@​ILIYANGERMANOV](https://togithub.com/ILIYANGERMANOV) in [https://github.com/arrow-kt/arrow/pull/3038](https://togithub.com/arrow-kt/arrow/pull/3038) - Fix text repetition in EffectScope's deprecation message by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3072](https://togithub.com/arrow-kt/arrow/pull/3072) - Introduce `NonEmptyCollection` by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3068](https://togithub.com/arrow-kt/arrow/pull/3068) - Set up Spotless by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3075](https://togithub.com/arrow-kt/arrow/pull/3075) - Update all dependencies by [@​renovate](https://togithub.com/renovate) in [https://github.com/arrow-kt/arrow/pull/3079](https://togithub.com/arrow-kt/arrow/pull/3079) - Add option to disable `inline` when using `@optics` by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3078](https://togithub.com/arrow-kt/arrow/pull/3078) - Update JS versions in `yarn.lock` by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3084](https://togithub.com/arrow-kt/arrow/pull/3084) - Enable Automatic Modules for JVM by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3071](https://togithub.com/arrow-kt/arrow/pull/3071) - Serialization module by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3077](https://togithub.com/arrow-kt/arrow/pull/3077) - Add missing docs for `Raise` operations by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3082](https://togithub.com/arrow-kt/arrow/pull/3082) - Add mapOrAccumulate extension in RaiseAccumulate by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/3086](https://togithub.com/arrow-kt/arrow/pull/3086) - Additional tests for `copy` in Optics by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3089](https://togithub.com/arrow-kt/arrow/pull/3089) - Apply Gradle Versioning in top project by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3092](https://togithub.com/arrow-kt/arrow/pull/3092) - Add missing Versioning plug-in to `arrow-core-retrofit` by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3093](https://togithub.com/arrow-kt/arrow/pull/3093) - Update `arrow-gradle-config` to 0.12-rc.4 by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3094](https://togithub.com/arrow-kt/arrow/pull/3094) - MemoizedDeepRecursiveFunction by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/3091](https://togithub.com/arrow-kt/arrow/pull/3091) - Add reset and barrierAction to CyclicBarrier. by [@​HSAR](https://togithub.com/HSAR) in [https://github.com/arrow-kt/arrow/pull/3055](https://togithub.com/arrow-kt/arrow/pull/3055) - \[HOTFIX] Fix main publish by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/3095](https://togithub.com/arrow-kt/arrow/pull/3095) ##### New Contributors - [@​DeoTimeTheGithubUser](https://togithub.com/DeoTimeTheGithubUser) made their first contribution in [https://github.com/arrow-kt/arrow/pull/3036](https://togithub.com/arrow-kt/arrow/pull/3036) - [@​vladd-g](https://togithub.com/vladd-g) made their first contribution in [https://github.com/arrow-kt/arrow/pull/3060](https://togithub.com/arrow-kt/arrow/pull/3060) - [@​yoxjames](https://togithub.com/yoxjames) made their first contribution in [https://github.com/arrow-kt/arrow/pull/3052](https://togithub.com/arrow-kt/arrow/pull/3052) - [@​kyay10](https://togithub.com/kyay10) made their first contribution in [https://github.com/arrow-kt/arrow/pull/3059](https://togithub.com/arrow-kt/arrow/pull/3059) - [@​jooohn](https://togithub.com/jooohn) made their first contribution in [https://github.com/arrow-kt/arrow/pull/3067](https://togithub.com/arrow-kt/arrow/pull/3067) - [@​ILIYANGERMANOV](https://togithub.com/ILIYANGERMANOV) made their first contribution in [https://github.com/arrow-kt/arrow/pull/3038](https://togithub.com/arrow-kt/arrow/pull/3038) - [@​HSAR](https://togithub.com/HSAR) made their first contribution in [https://github.com/arrow-kt/arrow/pull/3055](https://togithub.com/arrow-kt/arrow/pull/3055) **Full Changelog**: arrow-kt/arrow@1.2.0-RC...1.2.0 ### [`v1.1.5`](https://togithub.com/arrow-kt/arrow/releases/tag/1.1.5) [Compare Source](https://togithub.com/arrow-kt/arrow/compare/1.1.4...1.1.5) #### What's Changed - Remove `test` modules by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/2874](https://togithub.com/arrow-kt/arrow/pull/2874) - Mention Arrow 2.0 in README by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/2878](https://togithub.com/arrow-kt/arrow/pull/2878) - Prisms for Either by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/2877](https://togithub.com/arrow-kt/arrow/pull/2877) - Test 1.8.0 on CI by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2864](https://togithub.com/arrow-kt/arrow/pull/2864) - Implement 'align' using 'buildList' by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/2886](https://togithub.com/arrow-kt/arrow/pull/2886) - Improve debugging experience of leaked shift calls by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2884](https://togithub.com/arrow-kt/arrow/pull/2884) - Fix knitCheck & re-add check by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2887](https://togithub.com/arrow-kt/arrow/pull/2887) **Full Changelog**: arrow-kt/arrow@1.1.4...1.1.5 ### [`v1.1.4`](https://togithub.com/arrow-kt/arrow/releases/tag/1.1.4) [Compare Source](https://togithub.com/arrow-kt/arrow/compare/1.1.3...1.1.4) #### What's Changed - \[2743] Migrate internal use of CircuitBreaker double to duration by [@​mjmoore](https://togithub.com/mjmoore) in [https://github.com/arrow-kt/arrow/pull/2748](https://togithub.com/arrow-kt/arrow/pull/2748) - Fix typo by [@​valery1707](https://togithub.com/valery1707) in [https://github.com/arrow-kt/arrow/pull/2824](https://togithub.com/arrow-kt/arrow/pull/2824) - Make the server disconnect test more general by [@​lukasz-kalnik-gcx](https://togithub.com/lukasz-kalnik-gcx) in [https://github.com/arrow-kt/arrow/pull/2822](https://togithub.com/arrow-kt/arrow/pull/2822) - Update NonEmptyList.fromList deprecation to suggest `toOption()` instead by [@​StylianosGakis](https://togithub.com/StylianosGakis) in [https://github.com/arrow-kt/arrow/pull/2832](https://togithub.com/arrow-kt/arrow/pull/2832) - Improve Either.getOrHandle() docs by [@​lukasz-kalnik-gcx](https://togithub.com/lukasz-kalnik-gcx) in [https://github.com/arrow-kt/arrow/pull/2833](https://togithub.com/arrow-kt/arrow/pull/2833) - Correct `addressStrees` -> `addressStreet` in optics documentation by [@​vikrem](https://togithub.com/vikrem) in [https://github.com/arrow-kt/arrow/pull/2836](https://togithub.com/arrow-kt/arrow/pull/2836) - Arrow Fx: deprecate Platform#composeError, never and unit() by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2837](https://togithub.com/arrow-kt/arrow/pull/2837) - Backport Optics KSP plugin NPE on multiplatform fix by [@​cvb941](https://togithub.com/cvb941) in [https://github.com/arrow-kt/arrow/pull/2840](https://togithub.com/arrow-kt/arrow/pull/2840) - Refactor - [#​2812](https://togithub.com/arrow-kt/arrow/issues/2812) sequence separate performance by [@​Khepu](https://togithub.com/Khepu) in [https://github.com/arrow-kt/arrow/pull/2818](https://togithub.com/arrow-kt/arrow/pull/2818) - Use `super` equals and hashCode overrides for NonEmptyList by [@​RusticFlare](https://togithub.com/RusticFlare) in [https://github.com/arrow-kt/arrow/pull/2825](https://togithub.com/arrow-kt/arrow/pull/2825) - Resource API deprecation, and preparation for 2.x.x. & back port improvements by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2847](https://togithub.com/arrow-kt/arrow/pull/2847) - introduce iterable.toNonEmptyListOrNone() by [@​myuwono](https://togithub.com/myuwono) in [https://github.com/arrow-kt/arrow/pull/2843](https://togithub.com/arrow-kt/arrow/pull/2843) - \[PROPOSAL] Either API deprecation, and preparation for 2.x.x by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2830](https://togithub.com/arrow-kt/arrow/pull/2830) - Use major versions in GitHub Actions by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/2849](https://togithub.com/arrow-kt/arrow/pull/2849) - Weaken Either monoid dependencies to only require a semigroup on left by [@​mjvmroz](https://togithub.com/mjvmroz) in [https://github.com/arrow-kt/arrow/pull/2845](https://togithub.com/arrow-kt/arrow/pull/2845) - Do not reuse the name of the file in Optics KSP by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/2850](https://togithub.com/arrow-kt/arrow/pull/2850) - Additional deprecations, and backports for JVM by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2856](https://togithub.com/arrow-kt/arrow/pull/2856) - Update various versions by [@​serras](https://togithub.com/serras) in [https://github.com/arrow-kt/arrow/pull/2852](https://togithub.com/arrow-kt/arrow/pull/2852) - Add CountDownLatch by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2854](https://togithub.com/arrow-kt/arrow/pull/2854) - Add CyclicBarrier by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2857](https://togithub.com/arrow-kt/arrow/pull/2857) - Temp rollback error handling deprecations until 1.2.x by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2858](https://togithub.com/arrow-kt/arrow/pull/2858) - Setup Kover as test coverage tool by [@​MarkMarkyMarkus](https://togithub.com/MarkMarkyMarkus) in [https://github.com/arrow-kt/arrow/pull/2793](https://togithub.com/arrow-kt/arrow/pull/2793) - Fix Monad.either binary combat by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2867](https://togithub.com/arrow-kt/arrow/pull/2867) - Backport: MPP No Trace by [@​nomisRev](https://togithub.com/nomisRev) in [https://github.com/arrow-kt/arrow/pull/2869](https://togithub.com/arrow-kt/arrow/pull/2869) #### New Contributors - [@​mjmoore](https://togithub.com/mjmoore) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2748](https://togithub.com/arrow-kt/arrow/pull/2748) - [@​valery1707](https://togithub.com/valery1707) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2824](https://togithub.com/arrow-kt/arrow/pull/2824) - [@​lukasz-kalnik-gcx](https://togithub.com/lukasz-kalnik-gcx) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2822](https://togithub.com/arrow-kt/arrow/pull/2822) - [@​StylianosGakis](https://togithub.com/StylianosGakis) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2832](https://togithub.com/arrow-kt/arrow/pull/2832) - [@​vikrem](https://togithub.com/vikrem) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2836](https://togithub.com/arrow-kt/arrow/pull/2836) - [@​cvb941](https://togithub.com/cvb941) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2840](https://togithub.com/arrow-kt/arrow/pull/2840) - [@​RusticFlare](https://togithub.com/RusticFlare) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2825](https://togithub.com/arrow-kt/arrow/pull/2825) - [@​mjvmroz](https://togithub.com/mjvmroz) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2845](https://togithub.com/arrow-kt/arrow/pull/2845) - [@​MarkMarkyMarkus](https://togithub.com/MarkMarkyMarkus) made their first contribution in [https://github.com/arrow-kt/arrow/pull/2793](https://togithub.com/arrow-kt/arrow/pull/2793) **Full Changelog**: arrow-kt/arrow@1.1.3...1.1.4-rc.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/elide-dev/elide). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6InYzIn0=-->
1 task
nomisRev
added a commit
that referenced
this pull request
Apr 24, 2024
* The beginning of Arrow 2.0 * Resource Arrow 2.0 (#2786) * Flatten Resource ADT, maintain API * [Arrow 2.0] Effect without suspending shift (#2797) * Shift without suspend, inline all the rest * Add new error handlers signatures * Make ShiftCancellationException private * Rename Shift to Raise according to Slack Poll, and add some initial docs (#2827) * Remove all references to shift from new Arrow 2.0 code (#2834) * Remove all references to shift from new code * Update API files * Fixes merge conflict between main and arrow-2 (#2835) * Add Resource.allocated() to decompose Resource into it's allocate and… (#2820) * [2743] Migrate internal use of CircuitBreaker double to duration (#2748) * Fix typo (#2824) * Make the server disconnect test more general (#2822) * Update NonEmptyList.fromList deprecation to suggest `toOption()` instead (#2832) * Improve Either.getOrHandle() docs (#2833) * Improve allocated, and fix knit examples Co-authored-by: Jeff Martin <jeff@custommonkey.org> Co-authored-by: Martin Moore <martinmoorej@gmail.com> Co-authored-by: valery1707 <valery1707@gmail.com> Co-authored-by: Lukasz Kalnik <70261110+lukasz-kalnik-gcx@users.noreply.github.com> Co-authored-by: stylianosgakis <stylianos.gakis98@gmail.com> * Add Atomic module, and StateShift (#2817) * Two small deprecations * Add Atomic module, and StateShift. Implement ior through StateShift * Fix build * Fix atomic knit * Fix knit attempt #2 * Update API files * Remove references to shift * Change return type of raise to Nothing (#2839) * Change return type of raise to Nothing Implements #2805 * Update public api with ./gradlew apiDump * Suppress warnings for unreachable calls to fail in tests The test is verifying that no code will be executed after a call to raise, so it's actually testing the very behaviour that the compiler is warning us about. Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update API files * Increase timeout * Fix compiler bug with nested inline + while + return * Clean up ExitCase.fromError * Update API files@ * Feature/remove validated (#2795) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Remove CancellationExceptionNoTrace.kt after merge, and run apiDump * Add missing runnerJUnit5 for arrow-atomic JVM * Publish Arrow 2.0.0-SNAPSHOT (#2871) Co-authored-by: Javier Segovia Córdoba <7463564+JavierSegoviaCordoba@users.noreply.github.com> * Simplify optics to Traversal/Optional/Lens/Prism (#2873) * 'mapOrAccumulate' for Raise (#2872) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Fix problems with Atomic * Smaller timeouts * Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations (#2784) * Revert typo * Fix build * Fix ParMapJvmTest * Implement NonEmptyList using value class (#2911) * Fix merge w.r.t. Saga * apiDump * Test other return expression * change unalign signature (#2972) see discussion in #2960 (comment) #2960 (comment) --------- Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update after merge main * Fix :arrow-optics-ksp-plugin:compileKotlin * Fix Every instances * Move functions to arrow functions (#3014) * Bring back `Iso` (#3013) * Bring back Iso * API Dump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update BOM (#3019) * Fix andThen duplication (#3020) * Fix Knit * Fix weird problem with value classes * Update API docs * Update publish workflow Following the instructions in #3090 (comment) * No closing repo on snapshot * knit * Fix optics tests * Fix after merge * Refactor ParMapTest from Kotest Plugin to Kotlin-test runtime #3191 (#3221) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor: Use Kotlin-test runtime for arrow-fx-stm tests (#3224) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update all Gradle files to mention kotlin.test * Refactor ParZip2Test from Kotest Plugin to Kotlin-test runtime #3192 (#3222) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor ParZip3Test from Kotest Plugin to Kotlin-test runtime #3193 (#3223) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor GuaranteeCaseTest to use kotlin test (#3226) Closes #3190 * refactor: migrate NotEmptySetTest to kotlin-test (#3230) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * refactor: migrate EagerEffectSpec to kotlin-test (#3233) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor NullableSpec from Kotest Plugin to Kotlin-test runtime (#3236) #3153 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor BracketCaseTest to use kotlin test (#3237) Closes #3186 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Move arrow-functions tests to kotlin.test (#3243) * Inline `AtomicBoolean` (#3240) * Inline AtomicBoolean * Update API files --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: migrate MappersSpec to kotlin-test (#3248) * Refactor ResourceTestJvm from Kotest Plugin to Kotlin-test runtime (#3244) Closes #3213 * refactor: migrate FlowJvmTest to Kotlin-test (#3228) * Refactor ParZip9JvmTest from Kotest Plugin to Kotlin-test runtime (#3245) Closes #3211 * Refactor ParZip8JvmTest from Kotest Plugin to Kotlin-test runtime (#3246) Closes #3210 * refactor: migrate NumberInstancesTest to kotlin-test (#3232) * refactor: OptionTest to kotlin-test runtime (#3229) * Revert "Inline `AtomicBoolean` (#3240)" (#3279) This reverts commit a6f1e73. * Refactor ParZip6JvmTest from Kotest Plugin to Kotlin-test runtime (#3255) Closes #3208 * Refactor ParZip5JvmTest from Kotest Plugin to Kotlin-test runtime (#3256) Closes #3207 * Refactor ParZip3JvmTest from Kotest Plugin to Kotlin-test runtime (#3258) Closes #3205 * Refactor ParZip2JvmTest from Kotest Plugin to Kotlin-test runtime (#3259) Closes #3204 * Refactor ParMapJvmTest from Kotest Plugin to Kotlin-test runtime (#3260) Closes #3203 * Refactor ParZip4JvmTest from Kotest Plugin to Kotlin-test runtime (#3257) Closes #3206 * refactor: migrate RaiseAccumulateSpec to kotlin-test (#3250) * Refactor ParZip7JvmTest from Kotest Plugin to Kotlin-test runtime (#3247) Closes #3209 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update ComparisonKtTest.kt (#3274) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Update OptionSpec.kt (#3271) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Update TraceJvmSpec.kt (#3276) * Update TraceJvmSpec.kt * Update TraceJvmSpec.kt --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Update ParZip9Test.kt (#3265) * Update ParZip9Test.kt * Update ParZip9Test.kt * Update ParZip8Test.kt (#3266) * Update ParZip7Test.kt (#3267) * Update ParZip6Test.kt (#3268) * Update ParZip5Test.kt (#3269) * Update ParZip4Test.kt (#3270) * Refactor CountDownLatchSpec and CyclicBarrierSpec to use kotlin test (#3227) * Refactor CountDownLatchSpec to use kotlin test Closes #3187 * Refactor CyclicBarrierSpec to use kotlin test Closes #3188 --------- Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor NonEmptyListTest to kotlin-test (#3231) * Add kotlin test dependency * Refactor NonEmptyList Test to use kotlin test --------- Co-authored-by: Alejandro Serrano <trupill@gmail.com> * refactor: migrate EffectSpec to kotlin-test (#3234) * Refactor FlowTest to use kotlin test (#3238) Closes #3189 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * refactor: migrate IorSpec to kotlin-test (#3249) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * refactor: migrate ResultSpec to kotlin-test (#3251) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * refactor: migrate StructuredConcurrencySpec to kotlin-test (#3252) * refactor: migrate TraceSpec to kotlin-test (#3253) * refactor: migrate GeneratorsTest to kotlin-test (#3254) * Refactor RaceNJvmTest from Kotest Plugin to Kotlin-test runtime (#3261) Closes #3212 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update ArrowResponseEAdapterTest.kt (#3264) * Update ArrowResponseEAdapterTest.kt * Update ArrowResponseEAdapterTest.kt --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update CollectionsSyntaxTests.kt (#3273) * Update CollectionsSyntaxTests.kt * Update CollectionsSyntaxTests.kt --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update NonFatalJvmTest.kt (#3277) * Update ArrowEitherCallAdapterTest.kt (#3278) * Update ArrowEitherCallAdapterTest.kt * Update ArrowEitherCallAdapterTest.kt * Move tests from `serialization` and `functions` completely to `kotlin.test` (#3289) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix problems with tests * Remove a bunch of warnings in `arrow-2` (#3282) Co-authored-by: serras <serras@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Finish transition to `kotlin.test` of `retrofit` and `fx-coroutines` (#3291) * Fix problems with concurrency in tests, take 8 * Port rest of `arrow-core` to `kotlin.test` (#3292) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Implement `fixedRate` using monotonic time source (#3294) Co-authored-by: serras <serras@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Port `optics` tests to `kotlin.test` (#3295) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add or fix contracts in Raise (#3293) * Add or fix contracts in Raise * Make contracts less strict * Get back contract on Either * ignoreErrors should also be AT_MOST_ONCE --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Alternate `SingletonRaise` (#3328) Co-authored-by: Youssef Shoaib <canonballt@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: serras <serras@users.noreply.github.com> * Remove (unused) tests for high-arity module * Fix tests + Knit * Fix merge NullableSpec * Regression in Arb.list? * Fix test for nonEmptyList * Develocity warning * Fix merge problem with optics-ksp-plugin * Fix timeout in test --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Sam Cooper <54266448+roomscape@users.noreply.github.com> Co-authored-by: Marc Moreno Ferrer <ignis.fatue@gmail.com> Co-authored-by: Javier Segovia Córdoba <7463564+JavierSegoviaCordoba@users.noreply.github.com> Co-authored-by: Alphonse Bendt <370821+abendt@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andreas Storesund Madsen <andreas@asmadsen.no> Co-authored-by: molikuner <molikuner@gmail.com> Co-authored-by: Jonathan Lagneaux <lagneaux.j@gmail.com> Co-authored-by: Marcus Ilgner <mail@marcusilgner.com> Co-authored-by: Chris Black <2538545+chrsblck@users.noreply.github.com> Co-authored-by: Tejas Mate <hi.tejas@pm.me> Co-authored-by: HyunWoo Lee (Nunu Lee) <54518925+l2hyunwoo@users.noreply.github.com> Co-authored-by: serras <serras@users.noreply.github.com> Co-authored-by: Youssef Shoaib <canonballt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest .toOption() instead of Option.fromNullable(). Coming from a discussion in StackOverFlow here https://stackoverflow.com/a/73893138/9440211. Thought I'd contribute it myself since it seemed quite straightforward and Simon seemed positive to this change.
Feel free to edit or discuss if you want me to edit something else too.