Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Duration in Schedule #2895

Merged
merged 5 commits into from
Jan 23, 2023
Merged

Use Duration in Schedule #2895

merged 5 commits into from
Jan 23, 2023

Conversation

serras
Copy link
Member

@serras serras commented Jan 19, 2023 •
edited
Loading

Fixes #2744

I've only made the changes in the arrow-fx-resilience module, but they could be copied to arrow-fx-coroutines if desired.

@serras serras requested a review from a team January 19, 2023 21:43
@serras serras self-assigned this Jan 19, 2023
nomisRev
nomisRev approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

We can get rid of all the xxxNano code since that was a work-around to expose Duration in a binary compat way without losing precision. We can leave this for another PR though ☺️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023 •
edited
Loading

Kover Report

File Coverage [56.85%]
arrow-libs/fx/arrow-fx-resilience/src/commonMain/kotlin/arrow/fx/resilience/Schedule.kt 54.88%
arrow-libs/fx/arrow-fx-resilience/src/commonMain/kotlin/arrow/fx/resilience/flow.kt 100.00%
Total Project Coverage 41.85%

@nomisRev
Copy link
Member

@serras deprecation makes a lot sense indeed 👍 This gives users smooth transition to new module, and breaking change only in 2.0.0 🙌

@nomisRev nomisRev requested a review from a team January 23, 2023 07:49
@nomisRev nomisRev merged commit a0414b1 into main Jan 23, 2023
@nomisRev nomisRev deleted the as-schedule-duration branch January 23, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@i-walker i-walker i-walker approved these changes

Assignees

@serras serras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

["Improvement"] Use Duration directly inside Schedule instead of Double
3 participants
@serras @nomisRev @i-walker