-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Validated #2940
Merged
Merged
Deprecate Validated #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kover Report
|
nomisRev
commented
Feb 22, 2023
Awesome dev experience :) |
serras
approved these changes
Feb 23, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt
Outdated
Show resolved
Hide resolved
cc\ @Zordid This PR changes |
franciscodr
reviewed
Feb 23, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Feb 23, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Feb 23, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Feb 23, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Feb 23, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt
Outdated
Show resolved
Hide resolved
Ooof, thanks @franciscodr! Bunch of copy-paste mistakes 🙈 |
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
14 tasks
Any feedback, or comments on the PR still very welcome 🙏 Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested migration process using
ReplaceWith
:zip
->zipOrAccumulate
,getOrElse
, etc to theirtoEither()
equivalents usingReplace in entire project
action from IntelliJValidated
orValidatedNel
, and theirinvalid
,invalidNel()
, etc constructors. (This piece can potentially be scripted like https://gist.github.com/nomisRev/e01ddc354c84b8b626c23d024706b916)Replace in entire project
Either.toEither()
intermediate method=> Now all
Validated
usage should be somewhat automatically be replaced in the project in 3~4 steps.Refactoring looks like this:
Validated.Refactor.2.mov
Issues:
typealias ValidatedNel
doesn't add the importtoValidated
is unresolved after the refactor. We could remove it fromReplaceWith, making it an incorrect replacement. Then we might also consider removing the intermediate calls to
toEither()`.Separately also investigating if we can automate this further using OpenRewrite to offer a smooth and pain-free migration process.