Deprecate Either.toValidated() and Either.toValidatedNel() functions #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nomisRev in case you did not find it ;-) |
nomisRev
reviewed
Mar 10, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Validated.kt
Outdated
Show resolved
Hide resolved
i-walker
approved these changes
Mar 10, 2023
serras
reviewed
Mar 10, 2023
arrow-libs/core/arrow-core/src/commonMain/kotlin/arrow/core/Either.kt
Outdated
Show resolved
Hide resolved
…ther.kt Co-authored-by: Alejandro Serrano <trupill@gmail.com>
…lidated.kt Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
|
If somebody would like to merge, that would be great - so far I cannot merge myself. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the deprecation of
ValidatedandValidatedNelit seems reasonable to symmetrically also deprecate the functionsEither.toValidated()andEither.toValidatedNel().This way, users see that they should avoid creating
Validatedobjects.Symmetrically,
Validated.fromEither(...)had already been deprecated before.