Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrow-optics: speedup 'Arb.string()' related slow tests #3010

Merged
merged 2 commits into from
Mar 31, 2023
Merged

arrow-optics: speedup 'Arb.string()' related slow tests #3010

merged 2 commits into from
Mar 31, 2023

Conversation

abendt
Copy link
Contributor

@abendt abendt commented Mar 30, 2023 •
edited
Loading

Speedup some of the tests in arrow-optics on ios/mac/windows

Compare #3005 for details

@abendt abendt changed the title don't use Arb.string in Arb.list() or Arb.map() arrow-optics: don't use Arb.string in Arb.list() or Arb.map() Mar 30, 2023
@abendt
Copy link
Contributor Author

abendt commented Mar 30, 2023

before https://scans.gradle.com/s/qekgwivm3pzai/tests/overview

image

after https://scans.gradle.com/s/puwc55abx3ela/tests/overview

image

@abendt abendt changed the title arrow-optics: don't use Arb.string in Arb.list() or Arb.map() arrow-optics: speedup 'Arb.string()' related slow tests Mar 30, 2023
@abendt abendt marked this pull request as ready for review March 31, 2023 07:52
nomisRev
nomisRev approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're doing amazing work here @abendt 🙏 Really awesome getting these speed-ups 🙌
Thank you so much for taking this on.

@nomisRev nomisRev merged commit b8cce76 into arrow-kt:main Mar 31, 2023
@abendt abendt deleted the arrow-optics_test_performance branch January 18, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myuwono myuwono myuwono approved these changes

@nomisRev nomisRev nomisRev approved these changes

@gutiory gutiory gutiory approved these changes

@serras serras serras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abendt @serras @gutiory @nomisRev @myuwono