Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NullableSpec from Kotest Plugin to Kotlin-test runtime #3236

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Refactor NullableSpec from Kotest Plugin to Kotlin-test runtime #3236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c4b009
Refactor NullableSpec from Kotest Plugin to Kotlin-test runtime
abendt Oct 22, 2023
e0b98fb
Merge branch 'arrow-2' into arrow-2-nullableSpec
serras Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/raise/NullableSpec.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ package arrow.core.raise

import arrow.core.Either
import arrow.core.Some
import io.kotest.core.spec.style.StringSpec
import io.kotest.matchers.shouldBe
import io.kotest.property.Arb
import io.kotest.property.arbitrary.boolean
import io.kotest.property.arbitrary.int
import io.kotest.property.arbitrary.orNull
import io.kotest.property.checkAll
import kotlin.test.Test
import kotlinx.coroutines.test.runTest

@Suppress("UNREACHABLE_CODE")
class NullableSpec : StringSpec({
"ensure null in nullable computation" {
class NullableSpec {
@Test fun ensureNullInNullableComputation() = runTest {
checkAll(Arb.boolean(), Arb.int()) { predicate, i ->
nullable {
ensure(predicate)
Expand All @@ -21,7 +21,7 @@ class NullableSpec : StringSpec({
}
}

"ensureNotNull in nullable computation" {
@Test fun ensureNotNullInNullableComputation() = runTest {
fun square(i: Int): Int = i * i
checkAll(Arb.int().orNull()) { i: Int? ->
nullable {
Expand All @@ -31,69 +31,69 @@ class NullableSpec : StringSpec({
}
}

"short circuit null" {
@Test fun shortCircuitNull() = runTest {
nullable {
val number: Int = "s".length
(number.takeIf { it > 1 }?.toString()).bind()
throw IllegalStateException("This should not be executed")
} shouldBe null
}

"ensureNotNull short circuit" {
@Test fun ensureNotNullShortCircuit() = runTest {
nullable {
val number: Int = "s".length
ensureNotNull(number.takeIf { it > 1 })
throw IllegalStateException("This should not be executed")
} shouldBe null
}

"simple case" {
@Test fun simpleCase() = runTest {
nullable {
"s".length.bind()
} shouldBe 1
}

"multiple types" {
@Test fun multipleTypes() = runTest {
nullable {
val number = "s".length
val string = number.toString().bind()
string
} shouldBe "1"
}

"binding option in nullable" {
@Test fun bindingOptionInNullable() = runTest {
nullable {
val number = Some("s".length)
val string = number.map(Int::toString).bind()
string
} shouldBe "1"
}

"binding either in nullable" {
@Test fun bindingEitherInNullable() = runTest {
nullable {
val number = Either.Right("s".length)
val string = number.map(Int::toString).bind()
string
} shouldBe "1"
}

"binding either in nullable, ignore errors" {
@Test fun bindingEitherInNullableIgnoreErrors() = runTest {
nullable {
val number = Either.Right("s".length) as Either<Boolean, Int>
val string = ignoreErrors { number.map(Int::toString).bind() }
string
} shouldBe "1"
}

"short circuit option" {
@Test fun shortCircuitOption() = runTest {
nullable {
val number = Some("s".length)
number.filter { it > 1 }.map(Int::toString).bind()
throw IllegalStateException("This should not be executed")
} shouldBe null
}

"when expression" {
@Test fun whenExpression() = runTest {
nullable {
val number = "s".length.bind()
val string = when (number) {
Expand All @@ -104,7 +104,7 @@ class NullableSpec : StringSpec({
} shouldBe "1"
}

"if expression" {
@Test fun ifExpression() = runTest {
nullable {
val number = "s".length.bind()
val string = if (number == 1) {
Expand All @@ -116,7 +116,7 @@ class NullableSpec : StringSpec({
} shouldBe "1"
}

"if expression short circuit" {
@Test fun ifExpressionShortCircuit() = runTest {
nullable {
val number = "s".length.bind()
val string = if (number != 1) {
Expand All @@ -128,18 +128,18 @@ class NullableSpec : StringSpec({
} shouldBe null
}

"Either<Nothing, A> can be bind" {
@Test fun eitherOfNothingAndSomethingCanBeBound() = runTest {
nullable {
val either: Either<Nothing, Int> = Either.Right(4)
either.bind() + 3
} shouldBe 7
}

"Recover works as expected" {
@Test fun recoverWorksAsExpected() = runTest {
nullable {
val one: Int = recover({ null.bind<Int>() }) { 1 }
val two = 2.bind()
one + two
} shouldBe 3
}
})
}