Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline AtomicBoolean #3240

Merged
merged 6 commits into from
Oct 29, 2023
Merged

Inline AtomicBoolean #3240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b0935ef
Inline AtomicBoolean
serras Oct 24, 2023
10a6db7
Branch was auto-updated.
github-actions[bot] Oct 24, 2023
8ce9af9
Update API files
serras Oct 24, 2023
0d75c4d
Branch was auto-updated.
github-actions[bot] Oct 24, 2023
485aef5
Branch was auto-updated.
github-actions[bot] Oct 25, 2023
dbdb0e6
Merge branch 'arrow-2' into atomic-boolean-inline
serras Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions arrow-libs/core/arrow-atomic/api/arrow-atomic.api
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,28 @@
public final class arrow/atomic/AtomicBoolean {
public fun <init> (Z)V
public final fun compareAndSet (ZZ)Z
public final fun get ()Z
public final fun getAndSet (Z)Z
public final fun getValue ()Z
public final fun set (Z)V
public final fun setValue (Z)V
public static final synthetic fun box-impl (Ljava/util/concurrent/atomic/AtomicInteger;)Larrow/atomic/AtomicBoolean;
public static final fun compareAndSet-impl (Ljava/util/concurrent/atomic/AtomicInteger;ZZ)Z
public static fun constructor-impl (Z)Ljava/util/concurrent/atomic/AtomicInteger;
public fun equals (Ljava/lang/Object;)Z
public static fun equals-impl (Ljava/util/concurrent/atomic/AtomicInteger;Ljava/lang/Object;)Z
public static final fun equals-impl0 (Ljava/util/concurrent/atomic/AtomicInteger;Ljava/util/concurrent/atomic/AtomicInteger;)Z
public static final fun get-impl (Ljava/util/concurrent/atomic/AtomicInteger;)Z
public static final fun getAndSet-impl (Ljava/util/concurrent/atomic/AtomicInteger;Z)Z
public static final fun getValue-impl (Ljava/util/concurrent/atomic/AtomicInteger;)Z
public fun hashCode ()I
public static fun hashCode-impl (Ljava/util/concurrent/atomic/AtomicInteger;)I
public static final fun set-impl (Ljava/util/concurrent/atomic/AtomicInteger;Z)V
public static final fun setValue-impl (Ljava/util/concurrent/atomic/AtomicInteger;Z)V
public fun toString ()Ljava/lang/String;
public static fun toString-impl (Ljava/util/concurrent/atomic/AtomicInteger;)Ljava/lang/String;
public final synthetic fun unbox-impl ()Ljava/util/concurrent/atomic/AtomicInteger;
}

public final class arrow/atomic/AtomicBooleanKt {
public static final fun getAndUpdate (Larrow/atomic/AtomicBoolean;Lkotlin/jvm/functions/Function1;)Z
public static final fun loop (Larrow/atomic/AtomicBoolean;Lkotlin/jvm/functions/Function1;)Ljava/lang/Void;
public static final fun tryUpdate (Larrow/atomic/AtomicBoolean;Lkotlin/jvm/functions/Function1;)Z
public static final fun update (Larrow/atomic/AtomicBoolean;Lkotlin/jvm/functions/Function1;)V
public static final fun updateAndGet (Larrow/atomic/AtomicBoolean;Lkotlin/jvm/functions/Function1;)Z
public static final fun getAndUpdate-NCWaHEY (Ljava/util/concurrent/atomic/AtomicInteger;Lkotlin/jvm/functions/Function1;)Z
public static final fun loop-NCWaHEY (Ljava/util/concurrent/atomic/AtomicInteger;Lkotlin/jvm/functions/Function1;)Ljava/lang/Void;
public static final fun tryUpdate-NCWaHEY (Ljava/util/concurrent/atomic/AtomicInteger;Lkotlin/jvm/functions/Function1;)Z
public static final fun update-NCWaHEY (Ljava/util/concurrent/atomic/AtomicInteger;Lkotlin/jvm/functions/Function1;)V
public static final fun updateAndGet-NCWaHEY (Ljava/util/concurrent/atomic/AtomicInteger;Lkotlin/jvm/functions/Function1;)Z
}

public final class arrow/atomic/AtomicIntKt {
Expand Down
20 changes: 13 additions & 7 deletions arrow-libs/core/arrow-atomic/src/commonMain/kotlin/arrow/atomic/AtomicBoolean.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
package arrow.atomic

public class AtomicBoolean(value: Boolean) {
private val inner = AtomicInt(value.toInt())
import kotlin.jvm.JvmInline

@JvmInline
public value class AtomicBoolean private constructor(private val inner: AtomicInt) {
public constructor(value: Boolean): this(AtomicInt(value.toInt()))

public var value: Boolean
get() = inner.value != 0
get() = inner.value.toBoolean()
set(value) {
inner.value = value.toInt()
}
Expand All @@ -18,12 +21,15 @@ public class AtomicBoolean(value: Boolean) {
}

public fun getAndSet(value: Boolean): Boolean =
inner.getAndSet(value.toInt()) == 1

private fun Boolean.toInt(): Int =
if (this) 1 else 0
inner.getAndSet(value.toInt()).toBoolean()
}

private inline fun Boolean.toInt(): Int =
if (this) 1 else 0

private inline fun Int.toBoolean(): Boolean =
this != 0


/**
* Infinite loop that reads this atomic variable and performs the specified [action] on its value.
Expand Down