Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Racing DSL #3411
base: main
Are you sure you want to change the base?
Racing DSL #3411
Changes from 2 commits
4c317b0
0ba6b3c
86373a9
a81952b
4a11caf
6331500
bf91964
000e730
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
raise
shouldn't be considered a failure? Perhaps raising in such a way is conceptually the same asreturn
ing a value. Alternatively, we can have araceOrRaise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. That kind-of makes sense, but I'd still expect user to want to 'select'
E
and notA
but supporting both would be great.So how do you imagine the API:
A
)A
orE
)A
,E
orThrowable
)?? Do we need something that 'selects' first
A
orThrowable
?Potentially we can do a different extension when you reside within
Raise
, so an extensionRaise<E>.racing(...)
but then it's probably still possible to easily select the non-Raise variant 🤔.This probably doesn't yield the benefit we'd want since the non-Raise
racing
would get suggested whenRaise
doesn't match orRaise.racing
has an additional param.