Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common basic test cases for cache4k #3501

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

Sujin1135
Copy link
Contributor

I noticed that cache4k does not have test cases, So I thought I should create some basic ones.

Basic Test Cases

  • Verify saved data is returned correctly.
  • Verify get method should return null for an invalid key.

That's why I tried it right away. While I was working on it, I encountered an issue with java version of Gradle, So I fixed it as this file changes. (Java version 8 -> 17)

Screenshot 2024-10-09 at 2 08 18 AM

The issue related to com.android.library used in root build.gradle.kts and optics build.gradle.kts.

@Sujin1135 Sujin1135 force-pushed the test/added-cache4k-testcases branch from 01352a3 to dfdfd56 Compare October 11, 2024 08:51
@Sujin1135 Sujin1135 force-pushed the test/added-cache4k-testcases branch from dfdfd56 to 02a144a Compare October 28, 2024 10:10
@serras serras merged commit f423d55 into arrow-kt:main Nov 5, 2024
10 checks passed
@serras
Copy link
Member

serras commented Nov 5, 2024

Sorry for taking so long to merge this. It's wonderful to have people contributing test cases to ensure that we don't break things when moving forward :)

@Sujin1135
Copy link
Contributor Author

Sujin1135 commented Nov 10, 2024

@serras Thank you for merging and leaving a comment:) and... Could you let me know how to join this Slack channel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants