Refactor IO following Cats #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 10, 2017 20:33
pakoito
commented
Dec 10, 2017
| } | ||
| } | ||
| override fun <B> map(f: (A) -> B): IO<B> = | ||
| // Allowed to do 32 map operations in sequence before |
raulraja
approved these changes
Dec 11, 2017
|
|
||
| import kategory.Either | ||
|
|
||
| interface IOFrame<in A, out R> : (A) -> R { |
There was a problem hiding this comment.
Any way to make these private or protected so they are not abused in the IO public API?
| private typealias Callback = (Either<Throwable, Any?>) -> Unit | ||
|
|
||
| @Suppress("UNCHECKED_CAST") | ||
| object IORunLoop { |
There was a problem hiding this comment.
Same as previous comment regarding visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes IO at least an order of magnitude faster by following the changes in these diffs:
typelevel/cats-effect#90
typelevel/cats-effect#95
The second diff is still WIP so I'll keep an eye for any changes we can apply too.