Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dehumanize Support for Slavic Locales #1077

Merged
merged 2 commits into from
Dec 18, 2021
Merged

Conversation

anishnya
Copy link
Member

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • [ x] 🧪 Added tests for changed code.
  • [ x] 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • [ x] 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • [ x] 📚 Updated documentation for changed code.
  • [ x] ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Adds dehumanize support for all Slavic locales and closes #996.

@anishnya anishnya changed the title Added Dehumanize Support for Slavic locales Added Dehumanize Support for Slavic Locales Dec 18, 2021
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #1077 (4ed140f) into master (be57df5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1077   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2232      2237    +5     
  Branches       437       439    +2     
=========================================
+ Hits          2232      2237    +5     
Impacted Files Coverage Δ
arrow/constants.py 100.00% <ø> (ø)
arrow/arrow.py 100.00% <100.00%> (ø)
arrow/locales.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be57df5...4ed140f. Read the comment docs.

Copy link
Member

@krisfremen krisfremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishnya anishnya merged commit a2ebb7e into master Dec 18, 2021
MarkKoz added a commit to MarkKoz/arrow that referenced this pull request Dec 24, 2021
Since arrow-py#996 was fixed by arrow-py#1077, the test no longer needs to use the
incorrect data to work around the bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Humanize Format Relative Error For Multiple Granularities
2 participants