Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH Actions failing due to a change in Sphinx. #1114

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

krisfremen
Copy link
Member

Pull Request Checklist

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

Description of Changes

Fixes github actions that have been failing since the release of Sphinx 5.x where they deprecate usage of None for language in conf.py

@krisfremen krisfremen requested review from jadchaar and anishnya June 22, 2022 00:04
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1114 (55d7d36) into master (4357f8c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2314      2314           
  Branches       448       448           
=========================================
  Hits          2314      2314           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4357f8c...55d7d36. Read the comment docs.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadchaar jadchaar merged commit 7b5c1aa into arrow-py:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants