Fix type signature of Arrow.__getattr__ #1171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
tox
ormake test
to find out!).tox -e lint
ormake lint
to find out!).master
branch.Description of Changes
Arrow's
__getattr__
provides access todatetime
attributes that aren't handled by Arrow.It has this signature:
It should return
Any
, as not all attributes fromdatetime
areint
s.For example, in
arrow.now().tzname()
,tzname
is a function.I noticed that
__getattr__
implements two undocumented attributes:week
andquarter
. The should be split into their own methods, with a docstring.