Skip to content

You now have robust error handling for malformed format strings in Da… #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sushanth145
Copy link

@Sushanth145 Sushanth145 commented May 28, 2025

…teTimeParser.parse, preventing "list index out of range" or "no such group" errors, and getting clear, actionable error messages instead.

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

…teTimeParser.parse, preventing "list index out of range" or "no such group" errors, and getting clear, actionable error messages instead.
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.82%. Comparing base (403c29f) to head (2fe7e2e).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
arrow/parser.py 63.63% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master    #1212      +/-   ##
===========================================
- Coverage   100.00%   99.82%   -0.18%     
===========================================
  Files           10       10              
  Lines         2324     2340      +16     
  Branches       357      358       +1     
===========================================
+ Hits          2324     2336      +12     
- Misses           0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sushanth145
Copy link
Author

i will add the tests to i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant