Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add week timeframe to Polish locale #769

Merged
merged 4 commits into from
Apr 7, 2020

Conversation

akwodkiewicz
Copy link
Contributor

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 📚 Updated documentation for changed code.
    (:x: No documentation change needed.)
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

I've added missing week and weeks timeframes to Polish locale and also fixed the grammar errors in the existing entries.

@codecov-io
Copy link

codecov-io commented Apr 5, 2020

Codecov Report

Merging #769 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #769   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1696      1681   -15     
  Branches       288       288           
=========================================
- Hits          1696      1681   -15     
Impacted Files Coverage Δ
arrow/locales.py 100.00% <ø> (ø)
arrow/arrow.py 100.00% <0.00%> (ø)
arrow/parser.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3421379...35c54b7. Read the comment docs.

@systemcatch systemcatch self-requested a review April 6, 2020 14:02
@systemcatch systemcatch changed the title Fix Polish locale Add week timeframe to Polish locale Apr 6, 2020
Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for the contribution @akwodkiewicz!

@jadchaar
Copy link
Member

jadchaar commented Apr 6, 2020

Hey @akwodkiewicz, seems like a recent merge that contained some big changes to our testing suite was merged in and thus caused some conflicts. Mind resolving them so we can merge this in?

@systemcatch
Copy link
Collaborator

Conflicts don't look to bad, I can help with fixing if need be.

@systemcatch systemcatch merged commit 9a1df21 into arrow-py:master Apr 7, 2020
@akwodkiewicz
Copy link
Contributor Author

Thanks @systemcatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants