Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4.2 support #595

Closed
pawandubey opened this issue Mar 7, 2017 · 1 comment · Fixed by #596
Closed

Rails 4.2 support #595

pawandubey opened this issue Mar 7, 2017 · 1 comment · Fixed by #596

Comments

@pawandubey
Copy link
Contributor

pawandubey commented Mar 7, 2017

Trying out Koala 3.x with Rails 4.2.7 and it seems like it depends on json version >= 2.0 but rails itself locks it as json (>= 1.7.7, ~> 1.7).

So no way to use it with rails 4.2 apps as of now. Maybe drop json version to >= 1.7?

EDIT: I see that it was done to enable the quirks_mode option. Anyway around it?

@arsduo
Copy link
Owner

arsduo commented Mar 8, 2017

It wasn't actually necessary to up the JSON version -- 2.0 was supposed to fully support the JSON spec, but in the end I had to use quirks_mode. Since Rails 4 requires an earlier version, that's definitely the way to go -- Koala has to be compatible with Rails 4. Closing this and merging in the PR.

@arsduo arsduo closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants