Drop Json version to 1.8 to support Rails 4.2.x #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it work with Rails 4.2.x
|
Thank you so much for finding that. I really appreciate your testing the
pre-release version. I'll get this merged in this week.
…On Mar 7, 2017 00:39, "Pawan Dubey" ***@***.***> wrote:
Fixes #595 <#595>
Json 1.8.5 actually included some fixes to support Rails 4.2 [
ruby/json#311]
Koala can't be used with Rails 4.2 right now because it depends on Json 2,
whereas Rails 4.2 expects Json 1.x. Dropping the version to 1.8 fixes the
incompatibility.
- [ ] My PR has tests and they pass!
- [ ] The live tests pass for my changes (LIVE=true rspec -- unrelated
failures are okay).
- The PR is based on the most recent master commit and has no merge
conflicts.
------------------------------
You can view, comment on, or merge this pull request online at:
#596
Commit Summary
- Drop Json version to 1.8
File Changes
- *M* koala.gemspec
<https://github.com/arsduo/koala/pull/596/files#diff-0> (2)
Patch Links:
- https://github.com/arsduo/koala/pull/596.patch
- https://github.com/arsduo/koala/pull/596.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#596>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC8xU5s4McCh4v64fGQAGj_AXKjRAp9ks5rjPuLgaJpZM4MVGaW>
.
|
arsduo
reviewed
Mar 8, 2017
| @@ -25,5 +25,5 @@ Gem::Specification.new do |gem| | |||
|
|
|||
| gem.add_runtime_dependency("faraday") | |||
| gem.add_runtime_dependency("addressable") | |||
| gem.add_runtime_dependency("json", ">= 2.0") | |||
| gem.add_runtime_dependency("json", "~> 1.8") | |||
There was a problem hiding this comment.
I'm actually going to update this to be >= 1.8 -- otherwise it wouldn't work with 2.0.
|
@pawandubey I saw a koala upgrade to 3.0, and was wondering if someone from adwyze got a commit in. Sweet!
|
|
@pratik60 Haha, we got more commits than this in, check the changelog 😛 Was about time, I'd say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #595
Json 1.8.5 actually included some fixes to support Rails 4.2 ruby/json#311
Koala can't be used with Rails 4.2 right now because it depends on Json 2, whereas Rails 4.2 expects Json 1.x. Dropping the version to 1.8 fixes the incompatibility.
LIVE=true rspec-- unrelated failures are okay).