Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specs to run cleanly without deprecation warnings under RSpec 3.0.x #350

Closed
wants to merge 1 commit into from
Closed

Update specs to run cleanly without deprecation warnings under RSpec 3.0.x #350

wants to merge 1 commit into from

Conversation

petergoldstein
Copy link
Contributor

  1. Applied transpec to convert to RSpec 3.0.x syntax
  2. Updated rspec version in gemspec
  3. Fixed a few remaining post-transpec issues.

@arsduo
Copy link
Owner

arsduo commented Feb 1, 2014

This is fantastic! I didn't know about transpec before, but am definitely going to make use of it on other projects. Thanks!

@petergoldstein
Copy link
Contributor Author

I just rebased this branch against master - it should be fully merged and run green.

When I rebased I ran into a minor issue in the multipart_request_spec - spec was failing because a hash was being used to mock env, while in real requests env actually behaves like a Mash. The super call was failing when it couldn't find the body method. I added a simple stub to deal with this.

And yes, transpec is awesome. :)

@arsduo
Copy link
Owner

arsduo commented Feb 1, 2014

I found that myself today and fixed it -- turns out somewhere along the line they moved from using hashes to a dedicated Faraday::Env class.

This won't show as merged, since I manually merged it in and the diff has changed, but all the code changes are in master now. (Like here). Thanks again! I really appreciate it.

@arsduo arsduo closed this Feb 1, 2014
@petergoldstein petergoldstein deleted the feature/apply_transpec branch February 2, 2014 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants