Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package 4.1.1 #761

Closed
12 tasks done
arsenetar opened this issue Jan 12, 2021 · 27 comments
Closed
12 tasks done

Package 4.1.1 #761

arsenetar opened this issue Jan 12, 2021 · 27 comments

Comments

@arsenetar
Copy link
Owner

arsenetar commented Jan 12, 2021

  • Verify any other issues to fix before tag
  • Update Version to 4.1.1
  • Update Changelog
  • Package Windows 64 bit
  • Package Windows 32 bit
  • Package OSX Qt (experimental) Packaging has been fixed
  • Package OSX Cocoa
  • Package .deb (x64 only, also debian source archive)
  • Notify Ubuntu PPA maintainers
  • Notify Arch Linux maintainers
  • Make Github Release
  • Update website links for new packages.
@arsenetar arsenetar mentioned this issue Jan 12, 2021
12 tasks
@arsenetar arsenetar pinned this issue Jan 12, 2021
@necrevistonnezr
Copy link

Will 4.1.0 get a macOS release?

@arsenetar
Copy link
Owner Author

arsenetar commented Jan 13, 2021

@necrevistonnezr I could probably put up a 4.1.0 version for the macOS Cocoa version, although there are a few open items in that release, which would not be solved until a later release such as 4.1.1 (or potentially later). I am planning on pushing 4.1.1 fairly quickly due to some of the issues found with the translations, and a few other related items in the linux/windows side of things. If those issues did not come up, I was going to put up 4.1.0 versions for macOS.

There are "newer" test versions built off of almost 4.1.0 source in #753 as well as some of the observed issues with those builds the RC6 one is the latest over there.

Short answer is if I can get things sorted out for a 4.1.1 release in the near future there will not be 4.1.0 releases for macOS as I will just jump them to 4.1.1.

@necrevistonnezr
Copy link

Thanks for the info!

@qarmin
Copy link

qarmin commented Jan 13, 2021

4.1.0 deb version doesn't work on Ubuntu 20.04(also on Linux MInt 20.1), so it would be better to make it work in this version(#763)

@arsenetar
Copy link
Owner Author

@qarmin the 4.1.1 deb should work on Ubuntu 20.04 based systems when it is released.

@arsenetar
Copy link
Owner Author

@glubsy 4.1.1 should be good to package now for Arch.
@eugenesan 4.1.1 should be good to package for the PPA as well, unless you want to wait for deb files, which should be up soon.

@arsenetar
Copy link
Owner Author

Will attempt macOS packages this week.

@arsenetar
Copy link
Owner Author

Ok, took me a bit longer to get back to this, macOS packages might still have some issues, looks like it will not be 100% possible to package the Qt version, but might be able to get a version that runs on M1 macs. The Cocoa version does seem to package, the application has some errors right now which may be a bit irritating but scanning does work. I may post a test version in this issue.

@arsenetar
Copy link
Owner Author

arsenetar commented Apr 7, 2021

@SeaCelo, @emilbar, and @necrevistonnezr I have some test packages that I am going to link here if you are interested in trying. The qt version is not quite 100% packaged correctly as I think it will only work on M1 mac computers at this point (Seems like there is a way to get this to work on both, although that is going to take a bit more work.) The Qt version I build off of 3.9.2 instead of the system built in 3.8.x so hopefully that will show if some of the other issue that existed before in the cocoa version are here as well. This version seemed to be pretty functional to me, translations and local help are not working due to needing some path changes for the mac version so those are known issues at this point.

The cocoa version is packaged and should work on both M1 and intel mac computers. The application does throw some errors that are related to UI interactions that need to be updated in the cocoa version, this version is really just to verify it can perform scans and run on the systems.

Currently looking for some initial feedback to know if these work on systems aside from mine before spending more time on this.

Links are below:
https://voltaicideas.net/dupeGuru/TestPackages/4.1.1/dupeguru_4.1.1_Qt_B1.zip
https://voltaicideas.net/dupeGuru/TestPackages/4.1.1/dupeguru_4.1.1_cocoa_B1.dmg

@necrevistonnezr
Copy link

necrevistonnezr commented Apr 7, 2021 via email

@emilbar
Copy link

emilbar commented Apr 15, 2021

Cocoa version on macOS Mojave. So far so good.
It is fast on my very old Mac Pro (Early 2008). I'am glad you made a progress with this version for macOS.

I get same errors on startup like necrevistonnezr already wrote and additionally after I choose Scan duplicates from menu.

Application Identifier: com.hardcoded-software.dupeguru
Application Version: 4.1.1
Mac OS X Version: Version 10.14.6 (Build 18G7016)

Traceback (most recent call last):
  File "build/py/cocoa/inter.py", line 259, in pulse
  File "build/py/hscommon/gui/progress_window.py", line 109, in pulse
  File "build/py/core/app.py", line 316, in _job_completed
  File "build/py/core/app.py", line 301, in _results_changed
  File "build/py/hscommon/notify.py", line 35, in notify
  File "build/py/hscommon/notify.py", line 75, in dispatch
  File "build/py/core/gui/stats_label.py", line 21, in results_changed
AttributeError: 'NoneType' object has no attribute ‘refresh'

And this is the same like in dupeguru_osx_cocoa_4_0_4_RC6, but I can live with it until you resolve it :)
#753 (comment)

@eugenesan
Copy link
Contributor

I've just uploaded 4.1.1 packages to Launchpad PPA (It might take a few hours to actually build the packages).
The source packages are still generated by hand so no automatic uploads using Launchpad recipes, maybe in the future.

Please report back if you find any issues with the packages or require packages for releases besides last two LTSs (Bionic, Focal).

@emilbar
Copy link

emilbar commented Apr 16, 2021

And for QT version - this is all I can find in Console
Apr 16 08:18:49 Mac-Pro com.apple.xpc.launchd[1] (com.hardcoded-software.dupeguru.45468[12864]): Service exited with abnormal code: 1

@arsenetar
Copy link
Owner Author

arsenetar commented Apr 24, 2021

@emilbar Was this running the Qt version on an Intel or M1 based unit? Looks like it was Intel if "Mac-Pro" in your comment is correct. The Qt version will not run on Intel as packaged as one dependency is not built with both architectures (I need to figure out how to resolve that yet.)

@emilbar
Copy link

emilbar commented Apr 24, 2021

Yes it is Intel. I was just curious what happen, and if logs can somehow help you.

@HeckFinlay
Copy link

I've successfully carried out a Picture mode scan of around 60,000 png files with the Cocoa test package on an M1 MacBookAir. Apart from the error on launch (mentioned above by necrevistonnezr and emilbar) and the many, many hours needed for the "Almost done! Fiddling with results..." stage to complete, everything went smoothly. Some of the matching results I sampled did seem a bit iffy, but I wasn't too concerned about that for this particular scan.

The first scan I tried, unsuccessfully, was of 200,000+ small png files over several folders, and dupeGuru's memory consumption rose to 60GB before I cancelled the scan and restarted the machine. That was after being at "Almost done! Fiddling with results..." overnight, for perhaps 16 hours.

@glubsy
Copy link
Contributor

glubsy commented Jun 20, 2021

@OldThrashbarg This is interesting. Was this done with the 4.1.1 version? Sounds like a memory leak issue. Can you try again with a previous version, like 4.0.3 and see if you get the same problem?

@HeckFinlay
Copy link

HeckFinlay commented Jun 20, 2021

@OldThrashbarg This is interesting. Was this done with the 4.1.1 version? Sounds like a memory leak issue. Can you try again with a previous version, like 4.0.3 and see if you get the same problem?

@glubsy Yes, with 4.1.1. I previously had 4.0.3 installed and it would throw an exception immediately on running any image scan.

@arsenetar
Copy link
Owner Author

@glubsy & @OldThrashbarg, I would have to look into this more, but part of this issue is most likely due to what is going on during "Almost done! Fiddling with results..." step as across all platforms the memory usage can be observed even in older versions. It would require more investigation, and is mainly obvious when a large number of files > 1,000 is present often not being problematic for users until > 10,000 or more depending on the system. I would track this as part of #571 instead of here. Good to hear the test package ran for you.

@arsenetar
Copy link
Owner Author

I'm going to attempt to repackage the two test packages here to see if we can get something I feel can be released as a 4.1.1 package for OSX. Right now both have some issues. If I am still running into issues here or haven't figured it out in about two weeks, I will probably be moving on to setting up a release for 4.1.2. Although in that case, I will be putting up links on the download site directly to these test packages here instead of linking back to 4.0.3 only so at least users can get something a bit more up to date even if it is not quite 100%.

@gatto
Copy link

gatto commented Jul 15, 2021

Sorry, I have an M1 Mac, can I help in any way? I'm not technical at all in regards to building apps from source unfortunately

@arsenetar
Copy link
Owner Author

Ok this took quite a bit longer for me to really get time (and motivation) to attack this again. I think I now can build arm64 (for m1) and x64_86 (for intel) of the Qt version as now the packaging tool issues are resolved. I need to do a bit more to get a single version for Qt, but want to make sure these are working first:

@HeckFinlay
Copy link

Thanks, worked well for me using picture mode on a folder containing about 100 dupes. If I get time I’ll try it on an artificially dupe-dense folder.

Only issue I noticed was the clipping of the text in the Deletion Options dialog.
Screenshot 2021-08-04 at 11 39 08

@arsenetar
Copy link
Owner Author

@OldThrashbarg, thanks for the feedback, which version did you use and are you running this on an Intel or M1 mac?

@arsenetar
Copy link
Owner Author

@SeaCelo, @emilbar, and @necrevistonnezr probably should have tagged you guys so that you can see I have those new macOS packages for the Qt version.

@HeckFinlay
Copy link

@OldThrashbarg, thanks for the feedback, which version did you use and are you running this on an Intel or M1 mac?

ARM/M1 version on an M1 MBA.

@arsenetar
Copy link
Owner Author

Ok, I am publishing the combined Qt versions and a version of the Cocoa package to the release, they seem to work well for me and seems like they should continue working for others based on the previous testing done in this thread. The 4.1.1 release will have them shortly.

@arsenetar arsenetar unpinned this issue Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants