match all orientations #1127
match all orientations #1127
Conversation
|
I think the general idea here is good. I do think this should be an option instead of always matching all orientations as some users may not want to match images with different orientations. |
Hi @arsenetar , added option for rotated images |
- Update NullJob to subclass Job - Remove unnecessary size pre-read in _getMatches() as file sizes are already loaded during file scan via stat call - Skip ref check if contents scan as the scan already prevents this from happening, some of the other scans do things differently and need to be reviewed before removing this post step completely - Add guard on partial hashing to just hash the whole file if smaller than the offset and size and use the value for both the partial digest and digest
I have updated my fork and moved my changes from before.
|
This change massively slows down the scan, even when the "match all orientations" option is not enabled. A close to 10x slowdown is too much. I reverted this change on my local copy. |
|
@ne1188 thanks for reporting, please open an issue ticket referencing this PR |
Hi,
I was able to solve the problem with rotated/mirrored images.
Had to add cache blocks for all 8 orientation in the sqlite, but it is working fine.
Let me know if you need any edit.
Cheers,
Bruno