Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #456 & #461 #491

Merged
3 commits merged into from
Feb 26, 2018
Merged

Fix #456 & #461 #491

3 commits merged into from
Feb 26, 2018

Conversation

arsenetar
Copy link
Owner

This will fix issues #456 and #461

- Always display all language choices to fix #461
- Stop recursively removing installation directory as that
  is not a safe operation.  This may leave the installation
  directory after uninstallation but should be empty.  Fix #456.
- Add pypiwin32 for cx-freeze as it was issuing a warning
- Prevent version 5.1.0 of cx-freeze as it produces non-working
  packages for some reason.  Version 5.0.2 and 6.0b1 work fine.
Installer will now delete the files in the installation folder along
with the folder if it is empty.  Bumped minimum cx-Freeze version to
5.1.1 as files are structured differently in older versions.
@ghost
Copy link

ghost commented Feb 26, 2018

Can't test it for myself, but I'm sure it works :)

@ghost ghost merged commit f349f6a into arsenetar:master Feb 26, 2018
@arsenetar arsenetar deleted the 456+461 branch February 28, 2018 01:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant