Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging for 4.0.4 #593

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Update packaging for 4.0.4 #593

merged 1 commit into from
Oct 9, 2019

Conversation

eugenesan
Copy link
Contributor

@eugenesan eugenesan commented Aug 29, 2019

  • Fix main version (Don't use spaces and capitals in versions!)
  • Change debian changelog format in hscommon
  • Fix build cleanup
  • Switch to XZ compression
  • Update build instructions
  • Build single package for both Debian/Ubuntu
  • Update packaging

Requires: https://github.com/hsoft/hscommon/pull/6

* Fix main version (Don't use spaces and capitals in versions!)
* Change debian changelog format in hscommon
* Fix build cleanup
* Switch to XZ compression
* Update build instructions
* Build single package for both Debian/Ubuntu
* Update packaging
@eugenesan
Copy link
Contributor Author

eugenesan commented Aug 29, 2019

@arsenetar
Copy link
Owner

@eugenesan, thanks for the work on this.

Just a few items for clarity:

  1. Why is the changelog format being changed?
  2. Tell me about reasoning for the change to xz from gzip.
  3. Have you tested this packaging with debian?
  4. I see you added yourself as a maintainer for the package, do you intend to maintain packages for Ubuntu (ppa) and Debian?

@eugenesan
Copy link
Contributor Author

eugenesan commented Aug 30, 2019

@arsenetar

  1. Debian/Ubuntu packaging format is usually structured as {upstream-version}-{distribution-version}~{personal-version} DupeGuru scripts had the following format: {upstream-version}~{distribution-release}, which required minor correction especially since I've modified the script to build a single source package.
  2. GZIP considered a very old format and over the years was replaced with BZIP2 and in recent years with XZ (LZMA2), which provides ~40% savings in archives/packages sizes. Majority of distributions (even Windows) switched to XZ quite some time ago.
  3. No, I haven't tested on Debian but I don't see why it wouldn't work. DupeGuru generates only a debian source package and it is a job of distribution maintainers to tweak, test and upload it.
  4. It's a normal practice for a package maintainer to add himself to a maintainers list, especially when original maintainer abandoned the project. I was maintaining the package in my PPA for several years and for now, I am planning to continue. I am not a Debian maintainer.

P.S. To add this project to Debian (from where it will be automatically be pulled to Ubuntu), the project's structure must be overhauled.
Currently, the resulting application can't be built from a raw source and requires a "source package generation". Also, it imports external libraries into the tree which isn't a normal practice. Either the libs (hscommon, qlib) are integrated into the project (since no other project actually uses them) or they are packaged separately and dupeguru will depend on them as external packages. In addition, distributions will never accept a package which integrates external python libraries into the source tree since it brings a host of possible security and maintenance issues.
Unfortunately, at least for now, DupeGuru is destined to live in unofficial repos...

@arsenetar
Copy link
Owner

@eugenesan, thanks for the answers. Since this needs an updated hscommon, I am going to go ahead and pull the two submodules into this project. (This project is the only one using them any more from what I know, and this was planned for after a complete 4.04 release anyhow.) I will pull them as they are now. Once that is done could you update this PR to include the modification to hscommon?

@arsenetar
Copy link
Owner

Looks like I got the submodules pulled into this project successfully.

@arsenetar
Copy link
Owner

@eugenesan Could you add the modification to hscommon to this PR now that it is part of this repo? If not I will make that change after merging this. Seemed like it would be nice to keep it together.

@eugenesan
Copy link
Contributor Author

@arsenetar Sorry for the delay, I am mostly offline until next week.
If you won't merge it before, I'll do it next week.

@arsenetar arsenetar merged commit 8506d48 into arsenetar:master Oct 9, 2019
arsenetar added a commit that referenced this pull request Nov 7, 2019
Update changelog format to use changes from
https://github.com/hsoft/hscommon/pull/6/.  This allows for changes from
 #593 to work correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants