Fix silently failing on Windows #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm blindly merging this as I have no way to verify that it works. But with the tests and all, it looks good. |
|
@hsoft |
ghost
merged commit
|
BTW, thanks for the PR. Thanks @BoboTiG also for your second opinion. It helps mitigate the risks of blind merging. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
GetShortPathNameWreturned a buffer of0if the file could not be found, causing the return value ofget_short_path_nameto be an empty string, which caused the silent failure.Also added a test for the normal function of
send2trash.plat_win.