Updates for ruby 3.0 #1
Conversation
This reverts commit 51e713b.
|
Need to add some ruby versions to test matrix |
| @@ -0,0 +1,17 @@ | |||
| ## What is the current behavior? | |||
There was a problem hiding this comment.
cp -r ../jsonapi.rb .
.github/workflows/ci.yml
Outdated
| @@ -0,0 +1,29 @@ | |||
| name: CI | |||
|
|
|||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
similar to the cequel fork -- should we make this push on main + master branches only?
There was a problem hiding this comment.
I'm willing to add or delete
There was a problem hiding this comment.
I guess Tate can confirm -- I think the rationale was so that our test suite doesnt run tests twice
|
|
||
| strategy: | ||
| matrix: | ||
| ruby: ['2.7', '3.0', '3.1'] |
There was a problem hiding this comment.
No rails in the tests
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Runs code QA and tests | ||
| env: | ||
| RAILS_VERSION: ~> ${{ matrix.rails }} |
There was a problem hiding this comment.
But there is no rails in the matrix right? or in the tests? maybe this isnt needed
There was a problem hiding this comment.
bump -- isnt this not needed since no rails?
|
Similar to the other forks -- I think well need to add a rake task to publish the gem version to our repo |
Co-authored-by: Tate Thurston <tatethurston@gmail.com>
| @@ -37,11 +37,20 @@ module Protocol | |||
| end | |||
|
|
|||
| describe('RUBY-128') do | |||
| let(:permitted_classes) { [Cassandra::Protocol::CqlByteBuffer, Cassandra::Types::Map, Cassandra::Types::Simple, Symbol] } | |||
There was a problem hiding this comment.
total nit pick, feel free to ignore, but I'd make this a variable inside the if Psych branch since it's only used there. Generally you reserve let blocks for setup or assertions across multiple specs.
There was a problem hiding this comment.
I'm going to ignore, but I aspire to a higher level of rspecing
.github/workflows/ci.yml
Outdated
| - name: Runs code QA and tests | ||
| env: | ||
| RAILS_VERSION: ~> ${{ matrix.rails }} | ||
| COVERAGE: no | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install openjdk-8-jdk | ||
| bundle | ||
| bundle exec rake rspec |
There was a problem hiding this comment.
| - name: Runs code QA and tests | |
| env: | |
| RAILS_VERSION: ~> ${{ matrix.rails }} | |
| COVERAGE: no | |
| run: | | |
| sudo apt-get update | |
| sudo apt-get install openjdk-8-jdk | |
| bundle | |
| bundle exec rake rspec | |
| - run: | | |
| bundle exec rake rspec | |
| env: | |
| RAILS_ENV: test |
can we simplify this to the above? do we need to install openjdk-8-jdk?
There was a problem hiding this comment.
I think technically no, but will need it if bringing the integration suite in (though it may just become a transitive dep when bringing it cassa)
There was a problem hiding this comment.
I don't think RAILS_ENV matters, ruby != rails bro
Co-authored-by: Tate Thurston <tatethurston@gmail.com>
Co-authored-by: Tate Thurston <tatethurston@gmail.com>
Co-authored-by: Tate Thurston <tatethurston@gmail.com>
Co-authored-by: Tate Thurston <tatethurston@gmail.com>
There was a problem hiding this comment.
Could you update the allowed push host to only be our package repo in your PR?
Example: https://github.com/art19/cequel/blob/master/cequel.gemspec#L6
* Revert "Updates for ruby 3.0 (#1)" This reverts commit a134e1e. * Revert "Fix a case sensitivity issue when fetching the clustering order" This reverts commit 71e70bf. * Revert "Update docs.yaml to reflect recent work on docs" This reverts commit 5f41fa9. * Revert "changed 4.0+ to 4.0.x" This reverts commit aa6e17d. * Revert "readme and docs.yaml updates" This reverts commit 28cc9aa. * Revert "DOC-4040 update to docs.yaml (datastax#274)" This reverts commit c18f98e. * Revert "Add varchar to Cassandra::Types.text mapping (datastax#270)" This reverts commit 2c9070c. * Revert "Slight refactorig of prior commit. Main goal was to preserve ordering of hosts on the" This reverts commit 022906d. * Revert "Merge pull request datastax#267 from abicky/fix-replication-strategies-simple" This reverts commit 42c435d. * Revert "Minor spec fixes" This reverts commit 765f9c9. * Revert "Merge pull request datastax#265 from EasyPost:log_in_protocol" This reverts commit e1b8dcb. * Revert "Quick testing fix; make check for enable_materialized_views YAML config more" This reverts commit 8fdcfd2. * Revert "RUBY-331: Migrate to Jenkins pipelines (datastax#264)" This reverts commit 572dec0. * Revert "Revert "Fix a case sensitivity issue when fetching the clustering order"" This reverts commit 23ce3b9. * Revert "Revert "Updates for ruby 3.0 (#1)"" This reverts commit 1b3f6ea. * Version bump to 3.2.5.2
No description provided.