Skip to content

Commit

Permalink
Revert "feat: remove npm flags" (shadcn-ui#5707)
Browse files Browse the repository at this point in the history
* Revert "feat: remove npm flags (shadcn-ui#5686)"

This reverts commit 4ff64ba.

* chore: temporarily bring back flag
  • Loading branch information
shadcn authored Nov 4, 2024
1 parent b624e1a commit b38a82a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 46 deletions.
54 changes: 12 additions & 42 deletions content/docs/components/chart.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ description: Beautiful charts. Built using Recharts. Copy and paste into your ap
component: true
---

<Callout className="mb-6">

**Note:** If you are using charts with **React 19** or the **Next.js 15**, see the note [here](/docs/react-19#recharts).

</Callout>

<ComponentPreview
name="chart-bar-interactive"
className="-mt-4 [&_.preview]:p-0 [&_.preview]:border-t [&_.preview>div]:shadow-none [&_.preview>div]:border-none [&_.preview>div]:w-full [&_.preview]:lg:min-h-[404px]"
Expand Down Expand Up @@ -45,6 +51,12 @@ We do not wrap Recharts. This means you're not locked into an abstraction. When

## Installation

<Callout className="mt-4">

**Note:** If you are using charts with **React 19** or the **Next.js 15**, see the note [here](/docs/react-19#recharts).

</Callout>

<Tabs defaultValue="cli">

<TabsList>
Expand Down Expand Up @@ -83,27 +95,6 @@ npx shadcn@latest add chart
}
```

<Step>
To use recharts with React 19 and Next.js 15, you will need to override the
`react-is` dependency.{" "}
</Step>

Add the following to your `package.json`

```json title="package.json"
"overrides": {
"react-is": "^19.0.0-rc-69d4b800-20241021"
}
```

Note: the `react-is` version needs to match the version of React 19 you are using. The above is an example.

<Step>Run `npm install`</Step>

```bash
npm install
```

</Steps>

</TabsContent>
Expand Down Expand Up @@ -144,27 +135,6 @@ npm install recharts
}
```

<Step>
To use recharts with React 19 and Next.js 15, you will need to override the
`react-is` dependency.{" "}
</Step>

Add the following to your `package.json`

```json title="package.json"
"overrides": {
"react-is": "^19.0.0-rc-69d4b800-20241021"
}
```

Note: the `react-is` version needs to match the version of React 19 you are using. The above is an example.

<Step>Run `npm install`</Step>

```bash
npm install
```

</Steps>

</TabsContent>
Expand Down
6 changes: 2 additions & 4 deletions content/docs/react-19.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ title: Next.js 15 + React 19
description: Using shadcn/ui with Next.js 15 and React 19.
---

**shadcn/ui is now fully compatible with React 19!**

<Callout className="mt-6">
<Callout>
**The following guide applies to any framework that supports React 19**. I
titled this page "Next.js 15 + React 19" to help people upgrading to Next.js
15 find it. We are working with package maintainers to help upgrade to React
Expand Down Expand Up @@ -144,7 +142,7 @@ To make it easy for you track the progress of the upgrade, I've created a table
| [react-day-picker](https://www.npmjs.com/package/react-day-picker) || Works with flag for npm. Work to upgrade to v9 in progress. |
| [input-otp](https://www.npmjs.com/package/input-otp) || |
| [vaul](https://www.npmjs.com/package/vaul) || |
| [@radix-ui/react-icons](https://www.npmjs.com/package/@radix-ui/react-icons) | | |
| [@radix-ui/react-icons](https://www.npmjs.com/package/@radix-ui/react-icons) | 🚧 | See [PR #194](https://github.com/radix-ui/icons/pull/194) |
| [cmdk](https://www.npmjs.com/package/cmdk) || |

If you have any questions, please [open an issue](https://github.com/shadcn/ui/issues) on GitHub.
Expand Down

0 comments on commit b38a82a

Please sign in to comment.