feat(eslint-plugin): schedule-import-rule

[serikovlearning]

…ule (#845)

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
reatom	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 7, 2024 5:24pm

[krulod]

isImportICareAbout could have been an esquery selector. it should also handle imports from the core package as well as from framework

Suggested change

	ImportDeclaration(node: estree.ImportDeclaration) {
	lastImport = node
	if (isImportICareAbout(node)) {
	hasImport = true
	}
	},
	ImportDeclaration(node) {
	lastImport = node
	},
	"ImportSpecifier[source.value=/^@reatom\//][imported.name=/^(wrap|schedule)$]"(node: estree.ImportDeclaration) {
	hasImport = true
	},

[serikovlearning]

I tried by that not works for me.
I have no idea what's wrong and chatGpt don't help me.

Error trace:

Throw new SyntaxError(`Syntax error in selector "${rawSelector}" at position ${err.location.start.offset}: ${err.message}`);
                  ^
SyntaxError: Syntax error in selector "ImportSpecifier[source.value=/^@reatom//][imported.name=/^(wrap|schedule)$]" at position 39: Expected " ", "]", or [imsu] but "/" found.
Occurred while linting <input>
    at tryParseSelector (/*/reatom/node_modules/eslint/lib/linter/node-event-generator.js:196:19)
    at parseSelector (/*/reatom/node_modules/eslint/lib/linter/node-event-generator.js:214:28)
    at /*/reatom/node_modules/eslint/lib/linter/node-event-generator.js:265:30
    at Array.forEach (<anonymous>)
    at new NodeEventGenerator (/*/reatom/node_modules/eslint/lib/linter/node-event-generator.js:264:30)
    at runRules (/*/reatom/node_modules/eslint/lib/linter/linter.js:1077:32)
    at Linter._verifyWithoutProcessors (//reatom/node_modules/eslint/lib/linter/linter.js:1330:31)
    at Linter.verify (/*/reatom/node_modules/eslint/lib/linter/linter.js:1428:57)
    at runRuleForItem (/*/reatom/node_modules/eslint/lib/rule-tester/rule-tester.js:689:35)
    at testValidTemplate (/*/reatom/node_modules/eslint/lib/rule-tester/rule-tester.js:749:28)
    
    ````

[krulod]

this selector should work: ImportDeclaration[source.value=/^@reatom\x2f/] > ImportSpecifier[imported.name=/^(wrap|schedule)$/]

[serikovlearning]

Unfortuanlly, no.
Is that necessary to use selector instead of if statement?
I don't really good at eslint plugins. I don't undestand perfomance difference.

I think my writed code is more flexible and expandable in a way to add new ImportSpecifiers just into array. Espcially if some juniors come to help with plugins.
What do you think?

[artalar]

Please, rename all related things to "schedule import"

[artalar]

I mean, wrap-schedule-instead-of-ctx-schedule-rule.ts -> schedule-import-rule.ts and all related export and import variables names.

[serikovlearning]

I mean, wrap-schedule-instead-of-ctx-schedule-rule.ts -> schedule-import-rule.ts and all related export and import variables names.

done