Allows accept responses in JSON-RPC 1.0 format #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows accept responses in JSON-RPC 1.0 format; - Makes the library compatible with java 10+;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON-RPC v1.0 responses are very similar to v2.0. The jsonrpc field was added to responses of the second version of the protocol. In the first version of the protocol, this field is optional and may be absent.
This pool-request allows the simple-json-rpc library to accept responses in jsonrpc 1.0 format; See RequestBuilder class;
After this I done the enhancement, I attempted to deploy a project with the simple-json-rpc library and found out that there are dependencies that are not compatible with the latest Java versions. So then I looked through the code of the simple-json-rpc and found out that the core of the library is not using Java 17 itself. A major things using the latest Java language features is Tests and connected with them DTO objects there. So, I rewrote records in POJO manner, verified all tests are passing and that is it! Library is compatible with java 10+ now;
Please, accept the pool request, this will make it possible to import simple-json-rpc in a larger number of projects.