Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For friendly names that consider description #105

Closed
pepp86 opened this issue Jan 6, 2023 · 19 comments · Fixed by #106
Closed

For friendly names that consider description #105

pepp86 opened this issue Jan 6, 2023 · 19 comments · Fixed by #106
Labels
enhancement New feature or request

Comments

@pepp86
Copy link
Contributor

pepp86 commented Jan 6, 2023

What happened?

Name of the device in iobroker doesn't show up, neither the zigbee ID nor the description set in z2m

What did you expect to happen?

Device description set in z2m should be the device name in iobroker

How to reproduce it (minimal and precise)

No response

Adapter version

2.5.0

Log

No response

@pepp86 pepp86 added the problem Something isn't working label Jan 6, 2023
@buanet
Copy link

buanet commented Jan 6, 2023

Can you please provide some more information and maybe some screenshots?

Name should show up here:
ioB
image

Z2M
image

Description seems not to be included.

Regards,
André

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

image

Yep, was expecting the name to show up there, but as you see - nothing. Changed logging to silly now, no errors or any messages regarding names/description.

@nox309
Copy link
Contributor

nox309 commented Jan 6, 2023

I know the phenomenon, with me here actually always a restart of the adapter was enough, once also the Z2M itself. Have you ever done that?

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

Yep, in all possible scenarios. Seems that this adapter is not reading any values from z2m.

@nox309
Copy link
Contributor

nox309 commented Jan 6, 2023

but basically the communication of the adapter works, so if you change something in the ioB then that is also taken active?

If all this works or especially if it does not work, please pull once the current version of git. The version number has not changed, but there are already div. Changes incorporated.

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

Yep, communication works. It's for now only missing the description/name of the device.

@nox309
Copy link
Contributor

nox309 commented Jan 6, 2023

okay then please pull the current version from Git

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

No change - still missing names.

@o0shojo0o
Copy link
Contributor

What are your names, for example?

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

image
nothing special. Is there any chance to get a debug logging of the adapter to see what happens? From what I see, there is not. Enable silly logging, but only see the iobroker own messages (redis etc.)

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

To add, I've tested also a device without blanks in the description. Deleted all states and restarted. Nothing.

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

I get the following log now, when changing a description in z2m:

2023-01-06 12:59:31.666 - debug: zigbee2mqtt.0 (240481) Device: bridge/response/device/options not found, queue state in incStatsQueue! 2023-01-06 12:59:40.821 - debug: zigbee2mqtt.0 (240481) Device: bridge/response/device/options not found, queue state in incStatsQueue! 2023-01-06 12:59:41.587 - debug: zigbee2mqtt.0 (240481) Device: 901 not found, queue state in incStatsQueue! 2023-01-06 12:59:41.587 - debug: zigbee2mqtt.0 (240481) Device: bridge/response/device/options not found, queue state in incStatsQueue! 2023-01-06 12:59:41.587 - debug: zigbee2mqtt.0 (240481) Device: bridge/response/device/options not found, queue state in incStatsQueue!

@o0shojo0o
Copy link
Contributor

You have entered the names in the wrong place!
image

image

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

Yes/No - depends on the point of view. My friendly name always stays with the unique id of the device. Koenkk added the description for that purpose.

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 6, 2023

Here is the PR which implemented it in z2m
Koenkk/zigbee2mqtt#11493

Now, that we at least found the cause of the issue, are you able to look into the description field and use it, if there is a value?

@o0shojo0o
Copy link
Contributor

o0shojo0o commented Jan 6, 2023

Ok let's say it differently, for the adapter it is currently the wrong place.
Since I do not have the description as easy to access as I would need it was chosen this way, whether that still changes or is supplemented I have to look at time times.

I make but first this issues to, since that will have solved.

Create for the description please a new issues .

@o0shojo0o o0shojo0o reopened this Jan 6, 2023
@o0shojo0o o0shojo0o changed the title Device description doesn't show up For friendly names that consider description Jan 6, 2023
@o0shojo0o o0shojo0o added enhancement New feature or request and removed problem Something isn't working labels Jan 6, 2023
@o0shojo0o
Copy link
Contributor

I have looked at that, I think I can implement quite easily I test that right away :)

@o0shojo0o
Copy link
Contributor

@pepp86
Copy link
Contributor Author

pepp86 commented Jan 7, 2023

Works fine for me. Initial load uses description and updated names also get changed.

o0shojo0o added a commit that referenced this issue Jan 10, 2023
-   (o0shojo0o) added state `transition` for transition overwrite (-1 disabled overwrite) ([#101](#101))
-   (o0shojo0o) consideration of the description when creating the friendly name ([#105](#105))
-   (o0shojo0o) added state `effect` for groups ([#101](#101))
-   (o0shojo0o) fix state contact
-   (o0shojo0o) added handling for disabled devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants