Upgrade Django to 4.2 #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhwaniartefact
force-pushed
the
Upgrade-Django4.2
branch
from
0d57f21 to
c3ba033
Compare
|
This looks great @Dhwaniartefact, thanks! Let's leave this PR here until we milestone its issue. |
|
@Dhwaniartefact It seems you still need to clean some comments in the |
|
Sure let me do it. |
Dhwaniartefact
force-pushed
the
Upgrade-Django4.2
branch
2 times, most recently
from
cf15fb6 to
246116d
Compare
Dhwaniartefact
force-pushed
the
Upgrade-Django4.2
branch
from
246116d to
2fd80d7
Compare
replaceafill
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Looks good @Dhwaniartefact, but I left a couple of small requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets django-upgrade in pre-commit to upgrade Django to 4.2.
A few changes are worth mentioning:
The USE_L10N setting is removed as localized formatting of data will always be enabled. Ref: https://docs.djangoproject.com/en/4.2/ref/settings/#std-setting-USE_L10N
STATICFILES_STORAGE: Static files storage engine can be configured with the [STORAGES] setting. Ref: https://docs.djangoproject.com/en/4.2/ref/settings/#std-setting-STORAGES
Connected to archivematica/Issues#1624