Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove re_path URL dispatcher from urls #700

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

Dhwaniartefact
Copy link
Contributor

@Dhwaniartefact Dhwaniartefact commented Apr 2, 2024

Convert regular expressions re_path URL dispatcher to path in storage service APIs

Ref : https://docs.djangoproject.com/en/3.2/topics/http/urls/#path-converters

@Dhwaniartefact Dhwaniartefact self-assigned this Apr 2, 2024
Copy link
Member

@replaceafill replaceafill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @Dhwaniartefact, but I think you need to update a couple of views to handle comparisons correctly. I also left a question about a new trailing slash you have introduced.

Do you plan to remove the re_path calls from the storage_service/locations/api/resources.py module too? Is that even possible with tastypie in the mix?

storage_service/administration/urls.py Show resolved Hide resolved
storage_service/administration/urls.py Show resolved Hide resolved
storage_service/administration/urls.py Outdated Show resolved Hide resolved
storage_service/storage_service/urls.py Outdated Show resolved Hide resolved
@Dhwaniartefact Dhwaniartefact force-pushed the dev/issue-convert-re_path-to-path branch from 77c1bea to 5c964fd Compare April 3, 2024 23:21
@Dhwaniartefact
Copy link
Contributor Author

Do you plan to remove the re_path calls from the storage_service/locations/api/resources.py module too? Is that even possible with tastypie in the mix?

Tastypie resources are using re_path, which I am attempting to remove.

storage_service/administration/views.py Outdated Show resolved Hide resolved
storage_service/administration/views.py Outdated Show resolved Hide resolved
Dhwaniartefact and others added 2 commits April 5, 2024 11:56
Co-authored-by: Douglas Cerna <douglascerna@yahoo.com>
Co-authored-by: Douglas Cerna <douglascerna@yahoo.com>
@Dhwaniartefact
Copy link
Contributor Author

Do you plan to remove the re_path calls from the storage_service/locations/api/resources.py module too? Is that even possible with tastypie in the mix?

Tastypie resources are using re_path, which I am attempting to remove.

I am going to address removing of re_path from storage_service/locations/api/resources.py in a future PR.

@Dhwaniartefact Dhwaniartefact merged commit 622d6e2 into qa/0.x Apr 5, 2024
8 of 9 checks passed
@Dhwaniartefact Dhwaniartefact deleted the dev/issue-convert-re_path-to-path branch April 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants