Make the code Python 3 compatible #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaceafill
added
the
AMAUAT
sevein
approved these changes
May 25, 2021
This updates the MCPServer, MCPClient and dashboard to run in Python 2.7 and Python 3.6: * All the shebangs of the Python scripts have been updated to `#!/usr/bin/env python` so they can run in both versions * All the gearman tasks are now registered with a binary name and several encoding issues raised by the AMAUATs have been fixed * The `clientScripts` directory has been added to the MCPClient `PYTHONPATH` and all the `sys.path` modifications in its tests have been removed * A Django migration script has been added to make all the FPR `pythonScript`s compatible with both versions * A `PYTHON_VERSION` argument has been added to the docker development environment which allows the components to be run in both versions with Python 3.6 being the default one * The `ensure-no-mutable-globals.py` and `checkformigrations.sh` scripts are now also run in Python 3.6 in the GitHub test CI workflow * The `archivematica-acceptance-tests` submodule has been updated to include a fix for the `@transfer-backlog` tag * The GitHub AMAUAT CI workflow runs in both versions at the same time
replaceafill
force-pushed
the
dev/issue-1317-python3-compatibility
branch
from
d05c613 to
d4b9529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the MCPServer, MCPClient and dashboard to run in Python
2.7 and Python 3.6:
All the shebangs of the Python scripts have been updated to
#!/usr/bin/env pythonso they can run in both versionsAll the gearman tasks are now registered with a binary name and
several encoding issues raised by the AMAUATs have been fixed
The
clientScriptsdirectory has been added to the MCPClientPYTHONPATHand all thesys.pathmodifications in its tests havebeen removed
A Django migration script has been added to make all the FPR
pythonScripts compatible with both versionsA
PYTHON_VERSIONargument has been added to the docker developmentenvironment which allows the components to be run in both versions
with Python 3.6 being the default one
The
ensure-no-mutable-globals.pyandcheckformigrations.shscripts are now also run in Python 3.6 in the GitHub test CI
workflow
The
archivematica-acceptance-testssubmodule has been updated toinclude a fix for the
@transfer-backlogtagThe GitHub AMAUAT CI workflow runs in both versions at the same time
Connected to archivematica/Issues#1317