Shebangs use /usr/bin/env python2 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hwesta
added
the
Request: discussion
Huh, interesting - this behaviour seems different between GNU coreutils' env and BSD env. BSD env has no problem with a shebang of |
|
Looks fine to me! I assume the performance implications of dropping |
|
I'm wrong: apparently this is a Linux vs BSD thing, not a GNU env vs BSD env thing. https://twitter.com/jckarter/status/614583546921906177 |
|
Interesting! I just noticed it erroring on my machine with -OO and SO suggested because env didn't take params. Didn't realize it was different in BSD.
|
Update shebangs to use the environment's python2, instead of the system python. This wil make it easier to run in virtualenvs and on systems where /usr/bin/python is not python2.
qubot
force-pushed
the
dev/issue-xxxx-update-shebangs
branch
from
e535c7d
to
8f670a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update shebangs to use the environment's python2, instead of the system python. This will make it easier to run in virtualenvs, especially on systems where
/usr/bin/pythonis notpython2./usr/bin/envdoesn't take arguments, so removing-00where it exists.Any thoughts on changing
executeOrRunSubProcess.executeOrRunto interpret 'pythonScript' as 'python2' ?