arrange_contents: fix calling without the path parameter
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubot
force-pushed
the
dev/issue-XXXX-arrange_contents
branch
from
aa30f80
to
2869d1a
Compare
| except TypeError: | ||
| response = { | ||
| 'success': False, | ||
| 'message': 'Could not base64-decoded provided path: ' + path, |
There was a problem hiding this comment.
Use % or .format or str(), since + will fail if path is not a basestring.
There was a problem hiding this comment.
Fixed! Too much time in JS land...
qubot
force-pushed
the
dev/issue-XXXX-arrange_contents
branch
from
2869d1a
to
cfe0766
Compare
DEFAULT_ARRANGE_PATH is not base64-encoded; trying to decode it raises an exception.
qubot
force-pushed
the
dev/issue-XXXX-arrange_contents
branch
from
cfe0766
to
dffa086
Compare
qubot
force-pushed
the
dev/issue-XXXX-arrange_contents
branch
from
dffa086
to
0a93de7
Compare
| 'success': False, | ||
| 'message': 'Could not base64-decoded provided path: ' + path, | ||
| } | ||
| helpers.json_response(response, status_code=400) |
There was a problem hiding this comment.
https://docs.djangoproject.com/en/1.8/ref/request-response/#jsonresponse-objects :o Probably not for this PR but I'd like to replace helpers.json_response with JsonResponse
There was a problem hiding this comment.
Yeah, in the future let's make that change all at once.
|
👍 |
mamedin
pushed a commit
that referenced
this pull request
Sep 30, 2019
If a location is not a an AIP Storage-purposed (AS) location, then it should not be possible to assign a replicator location to it. Fixes issue #268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFAULT_ARRANGE_PATHis not base64-encoded; trying to decode it raises an exception.