copy_to_arrange: "objects" shouldn't be dragged onto arrange root #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubot
force-pushed
the
dev/issue-8957-arrange_objects_contents
branch
from
751a543
to
d131f71
Compare
|
👍 |
qubot
force-pushed
the
dev/issue-8957-arrange_objects_contents
branch
from
d131f71
to
ad8651f
Compare
|
Cherry-picked to qa/1.5.x as 2817ee6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We normally disallow dragging individual files into arrange root, and only allow dragging directories. However, if the "objects" directory is dragged, we have special behaviour to skip that directory and instead copy over its paths as if each of those had been dragged instead. That special-casing happens after we check whether the path being dragged over is a file or directory, though, which means "objects" passes the check - even though that would result in individual files being copied into the root of arrange.