Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArchivesSpace.find_by_field fixes #285

Merged
merged 3 commits into from
Sep 15, 2015
Merged

ArchivesSpace.find_by_field fixes #285

merged 3 commits into from
Sep 15, 2015

Conversation

mistydemeo
Copy link
Contributor

  • Fixes returning resource_components, which have a different field name for identifiers.
  • Limits the returned types to resources and resource components.

@Hwesta
Copy link
Contributor

Hwesta commented Sep 15, 2015

👍

@Hwesta
Copy link
Contributor

Hwesta commented Sep 15, 2015

Tests? Do tests still pass?

@mistydemeo
Copy link
Contributor Author

Updated tests; they pass now.

@Hwesta
Copy link
Contributor

Hwesta commented Sep 15, 2015

👍

@qubot qubot merged commit aeede9a into qa/1.x Sep 15, 2015
@qubot qubot deleted the dev/issue-XXXX-identifier_field branch September 15, 2015 00:55
@Hwesta
Copy link
Contributor

Hwesta commented Sep 21, 2015

Cherry-picked into qa/1.5.x as 29d1601 555997f abc45b8

@Hwesta Hwesta added this to the 1.5.0 milestone Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mistydemeo @Hwesta @qubot