METS: Handle empty rows in metadata.csv #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Run test | ||
| dc = archivematicaCreateMETSMetadataCSV.parseMetadataCSV('metadata.csv') | ||
| # Verify | ||
| assert dc |
There was a problem hiding this comment.
Maybe test the number of rows?
qubot
force-pushed
the
dev/issue-9386-metadata-csv-blank-row
branch
from
10d7fb5
to
6b6ea0c
Compare
|
👍 |
Skip empty rows when parsing a metadata.csv
qubot
force-pushed
the
dev/issue-9386-metadata-csv-blank-row
branch
from
6b6ea0c
to
63a5503
Compare
|
Also cherry-picked to 1.5 as 4de2099 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip empty rows when parsing a metadata.csv