Matching GUI: tweaks and fixes #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'sort_by': sort_by, | ||
| 'sort_direction': sort_direction, | ||
| 'uuid': uuid, | ||
| }) |
qubot
force-pushed
the
dev/issue-9444-filter-select-all
branch
from
31eccf7
to
5dca94f
Compare
|
👍 |
Hwesta
changed the title
qubot
force-pushed
the
dev/issue-9444-filter-select-all
branch
from
5dca94f
to
a7eb211
Compare
When selecting all, only select if the element is visible and not disabled.
Resource component display (views_as.ingest_upload_as_resource_component) don't know the resource_id, so don't require it for the breadcrumbs. Be explicit about what is being passed to the template.
Convert everything to lower case in JS when sorting.
Sort by dates as strings, no semantic parsing.
qubot
force-pushed
the
dev/issue-9444-filter-select-all
branch
from
a7eb211
to
9d3ecb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering in the matching GUI, don't select checkboxes that aren't visible or are disabled. Also, fix viewing resource component and be explicit about what's sent to the template.
Update: Sorting is now case insensitive.
Update: Add sorting by date. This works best with artefactual-labs/agentarchives#29
This may also be merged into 1.5