Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few typos and other spelling issues #265

Merged

Conversation

eviau-artefactual
Copy link
Contributor

Related to #257 .

@eviau-artefactual
Copy link
Contributor Author

If you prefer I can make one big PR with all the typos - or I can try to small batch ? Let me know !

Copy link
Contributor

@melaniekung melaniekung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@melaniekung melaniekung self-requested a review February 23, 2024 21:29
@eviau-artefactual
Copy link
Contributor Author

There are still typos left, I will open a PR with the following ones.

I will squash and merge this - it seems to be more appropriate in this case ?

For the commit message - I took advice in the wiki, let me know for future messages if there is something I should take in account ?

@eviau-artefactual eviau-artefactual merged commit 83d9c5d into artefactual:2.8 Feb 26, 2024
1 check passed
eviau-artefactual added a commit that referenced this pull request Feb 27, 2024
Enabling spellchecking to allow us to find typos automatically in new PRs.

Previous PRs involved fixing existing typos: #269, #265 

This PR is about:

* add sphinxcontrib-spelling to requirements
* use sphinx-build -b spelling in the Makefile. `make test` runs it
* update configuration and set it up
* creating a correctly spelled spelling_wordlist.txt to be used when spellchecking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants