Add validation for static page slugs. (#1703) (#1705)

artefactual · Nov 7, 2023 · 9bd6f13 · 9bd6f13
1 parent 6cb1412
commit 9bd6f13
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/apps/qubit/modules/staticpage/templates/editSuccess.php b/apps/qubit/modules/staticpage/templates/editSuccess.php
@@ -28,9 +28,9 @@
         <?php echo render_field($form->title, $resource); ?>
 
         <?php if ($resource->isProtected()) { ?>
-          <?php echo $form->slug->renderRow(['class' => 'readOnly', 'disabled' => 'disabled']); ?>
+          <?php echo $form->slug->renderRow([['class' => 'readOnly'], 'disabled' => 'disabled']); ?>
         <?php } else { ?>
-          <?php echo $form->slug->renderRow(); ?>
+          <?php echo $form->slug->renderRow(['pattern' => '^[a-zA-Z][a-zA-Z0-9\-_]*$']); ?>
         <?php } ?>
 
         <?php echo render_field($form->content, $resource, ['class' => 'resizable']); ?>

diff --git a/lib/helper/QubitHelper.php b/lib/helper/QubitHelper.php
@@ -37,6 +37,10 @@ function render_field($field, $resource = null, array $options = [])
     $div = null;
     $culture = sfContext::getInstance()->user->getCulture();
 
+    if (isset($options['pattern'])) {
+        $options['pattern'] = '^[a-zA-Z][a-zA-Z0-9\-_]*$';
+    }
+
     $resourceRaw = sfOutputEscaper::unescape($resource);
     if (isset($resourceRaw) && $culture != $resourceRaw->sourceCulture) {
         if ($resourceRaw instanceof QubitSetting) {

diff --git a/plugins/arDominionB5Plugin/modules/staticpage/templates/editSuccess.php b/plugins/arDominionB5Plugin/modules/staticpage/templates/editSuccess.php
@@ -35,9 +35,9 @@
             <?php echo render_field($form->title, $resource); ?>
 
             <?php if ($resource->isProtected()) { ?>
-              <?php echo render_field($form->slug, null, ['disabled' => 'disabled']); ?>
+              <?php echo render_field($form->slug, null, ['disabled' => 'disabled', 'type' => 'url']); ?>
             <?php } else { ?>
-              <?php echo render_field($form->slug); ?>
+              <?php echo render_field($form->slug, null, ['pattern' => '^[a-zA-Z0-9\-_]+$']); ?>
             <?php } ?>
 
             <?php echo render_field($form->content, $resource); ?>