Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BS5 Theme: change BS5 navbar-toggler-icon to Font Awesome icon #1688

Closed
phalene-bytes opened this issue Oct 25, 2023 · 0 comments
Closed

BS5 Theme: change BS5 navbar-toggler-icon to Font Awesome icon #1688

phalene-bytes opened this issue Oct 25, 2023 · 0 comments
Assignees
@phalene-bytes
Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: enhancement An improvement to existing functionality.
Milestone
2.8.0

Comments

@phalene-bytes
Copy link
Contributor

Benefits from implementing this change:

  • Consistency: aligns with approach to using Font Awesome icons/classes throughout AtoM
  • Flexibility and Control: grants more control over the icon appearance, making it easier to create custom themes
  • Automation: updates navbar icon's appearance automatically and in sync with the other navbar icons, with minimal effort
@phalene-bytes phalene-bytes added Type: enhancement An improvement to existing functionality. good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. labels Oct 25, 2023
@phalene-bytes phalene-bytes self-assigned this Oct 25, 2023
phalene-bytes added a commit that referenced this issue Oct 26, 2023
@phalene-bytes
Update navbar toggler icon (#1688)
b29c459
phalene-bytes added a commit that referenced this issue Oct 31, 2023
@phalene-bytes
Update navbar toggler icon (#1688)
56e3b53
phalene-bytes added a commit that referenced this issue Nov 1, 2023
@phalene-bytes
Update navbar toggler icon (#1688)
d3b3113
phalene-bytes added a commit that referenced this issue Nov 20, 2023
@phalene-bytes
Update navbar toggler icon (#1688) (#1689)
e78c42b 
Updates navbar toggler icon from BS5 icon/class to Font Awesome icon for consistency and easier client BS5 theme customization
@anvit anvit added this to the 2.8.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phalene-bytes phalene-bytes

Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: enhancement An improvement to existing functionality.
Projects
None yet
Milestone
2.8.0
Development

No branches or pull requests
2 participants
@anvit @phalene-bytes