Fix repeated build-nested-set warning (#1634) #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvit
requested changes
Oct 17, 2023
There was a problem hiding this comment.
I left some comments on a couple of minor issues, but otherwise this works as expected! Thanks @phalene-bytes!
anvit
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Sorry, another minor nitpick! — the commit message header should be 50 characters max, and we usually have the issue number in the brackets at the end (this helps with GitHub's issue linking). I'd suggest amending the commit message to be less than 50 characters, and using the commit message body (72 characters per line) if you need more than 50 characters.
phalene-bytes
force-pushed
the
dev/issue-1634-build-nested-set-warning-repeats
branch
from
3f9541b to
84f99db
Compare
phalene-bytes
force-pushed
the
dev/issue-1634-build-nested-set-warning-repeats
branch
from
84f99db to
f4fa981
Compare
phalene-bytes
changed the title
phalene-bytes
changed the title
anvit
added
the
Type: bug
phalene-bytes
deleted the
dev/issue-1634-build-nested-set-warning-repeats
branch
phalene-bytes
added a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes "Note: you will need to rebuild your search index for updates to show up properly in search results." out of recursivelyUpdateTree() function