Revert "Fix missing Bootstrap imports. (#1694)" #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvit
added
the
Type: bug
jraddaoui
approved these changes
Nov 17, 2023
|
Thanks @anvit! We were talking about the importance of |
anvit
force-pushed
the
dev/rollback-issue-1694
branch
from
89e4c0e to
4875a22
Compare
anvit
force-pushed
the
dev/rollback-issue-1694
branch
from
4875a22 to
9ada3bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert (#1694) since Bootstrap 5.2.0 and above introduce breaking changes. A couple of major issues this introduces is that it broke colours and padding for several sections in their
_reboot.scss. Will revisit #1694 after AtoM 2.8 to fix any breaking changes introduced by recent versions of bootstrap.