-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI data integrity repair tool #1725
Conversation
1b50dd8
to
6f68973
Compare
6f68973
to
e501539
Compare
d2d7e1f
to
2ff4682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adapting this @anvit and sorry for the delay on the review.
I don't know what are the plans for documentation, but we should explain somewhere the meaning of the CSV and the issues that can be found there. |
Add a CLI tool for performing data integrity checks and repairing or deleting broken records.
2ff4682
to
b8be3e9
Compare
- Fix indentation - Change calls to log to logSection - Move duplicated calls to report outside the switch - Remove csv filename extension check - Update help message, and clarify the .csv file extension
b8be3e9
to
6588b07
Compare
@jraddaoui Just addressed the feedback! Not sure why PHP-CS fixer didn't catch indentation issues because it seems to be catching other things in the file just fine, but those should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anvit!
Remove the stringEndsWith function which was unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks Anvit!
Add a CLI tool for performing data integrity checks and repairing or deleting broken records.
(Adapted from @jraddaoui's data integrity script into a CLI task)