Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI data integrity repair tool #1725

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Add CLI data integrity repair tool #1725

merged 3 commits into from
Mar 19, 2024

Conversation

anvit
Copy link
Contributor

@anvit anvit commented Dec 6, 2023

Add a CLI tool for performing data integrity checks and repairing or deleting broken records.

(Adapted from @jraddaoui's data integrity script into a CLI task)

@anvit anvit added work-in-progress Type: feature New functionality. labels Dec 6, 2023
@anvit anvit self-assigned this Dec 6, 2023
@anvit anvit force-pushed the dev/data-integrity-tool branch from 1b50dd8 to 6f68973 Compare December 6, 2023 19:20
@anvit anvit force-pushed the dev/data-integrity-tool branch from 6f68973 to e501539 Compare December 19, 2023 17:15
@anvit anvit force-pushed the dev/data-integrity-tool branch from d2d7e1f to 2ff4682 Compare January 15, 2024 20:08
@anvit anvit requested review from a team and melaniekung January 15, 2024 20:10
@anvit anvit added this to the 2.8.1 milestone Jan 15, 2024
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adapting this @anvit and sorry for the delay on the review.

lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
@jraddaoui
Copy link
Contributor

I don't know what are the plans for documentation, but we should explain somewhere the meaning of the CSV and the issues that can be found there.

@anvit anvit modified the milestones: 2.8.1, 2.9.0 Mar 13, 2024
Add a CLI tool for performing data integrity checks and repairing or
deleting broken records.
@anvit anvit force-pushed the dev/data-integrity-tool branch from 2ff4682 to b8be3e9 Compare March 19, 2024 16:47
- Fix indentation
- Change calls to log to logSection
- Move duplicated calls to report outside the switch
- Remove csv filename extension check
- Update help message, and clarify the .csv file extension
@anvit anvit force-pushed the dev/data-integrity-tool branch from b8be3e9 to 6588b07 Compare March 19, 2024 16:49
@anvit anvit requested a review from jraddaoui March 19, 2024 17:00
@anvit
Copy link
Contributor Author

anvit commented Mar 19, 2024

@jraddaoui Just addressed the feedback! Not sure why PHP-CS fixer didn't catch indentation issues because it seems to be catching other things in the file just fine, but those should be fixed now

Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anvit!

lib/task/tools/dataIntegrityRepairTask.class.php Outdated Show resolved Hide resolved
Remove the stringEndsWith function which was unused
Copy link
Contributor

@melaniekung melaniekung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks Anvit!

@anvit anvit merged commit 1154198 into qa/2.x Mar 19, 2024
6 checks passed
@anvit anvit deleted the dev/data-integrity-tool branch March 19, 2024 20:55
@anvit anvit modified the milestones: 2.9.0, 2.8.2 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature New functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants